Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15129 - Cookies::set() options parameter fixed #15150

Merged
merged 1 commit into from
Sep 11, 2020
Merged

T15129 - Cookies::set() options parameter fixed #15150

merged 1 commit into from
Sep 11, 2020

Conversation

zsilbi
Copy link
Member

@zsilbi zsilbi commented Sep 11, 2020

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG

Small description of change:

Fixed Phalcon\Http\Response\Cookies::set() to utilize the options parameter correctly.
Thank you @michalzielanski, for your suggestions #15129 (comment).

Thanks,
zsilbi

@zsilbi zsilbi added the 4.1.0 label Sep 11, 2020
@zsilbi zsilbi self-assigned this Sep 11, 2020
@zsilbi zsilbi linked an issue Sep 11, 2020 that may be closed by this pull request
[BUG]: Cookie samesite not effect #15129
Closed
@zsilbi zsilbi requested a review from ruudboon September 11, 2020 10:18
@Jeckerson Jeckerson added the bug A bug report label Sep 11, 2020
jenovateurs
jenovateurs approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@jenovateurs jenovateurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jeckerson Jeckerson merged commit fbf453e into phalcon:4.1.x Sep 11, 2020
@zsilbi zsilbi mentioned this pull request Sep 28, 2020
Closed
@zsilbi zsilbi deleted the T15129-cookie-options branch September 29, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

@Jeckerson Jeckerson Jeckerson approved these changes

@jenovateurs jenovateurs jenovateurs approved these changes

@ruudboon ruudboon Awaiting requested review from ruudboon

Assignees

@zsilbi zsilbi

Labels
bug A bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Cookie samesite not effect
4 participants
@zsilbi @niden @Jeckerson @jenovateurs