-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Cookie samesite not effect #15129
Labels
bug
A bug report
Comments
How do you declare cookies service? |
here is bug: cphalcon/phalcon/Http/Response/Cookies.zep Line 246 in 634e723
should be: [name, value, expire, path, secure, domain, httpOnly, options] and here: cphalcon/phalcon/Http/Response/Cookies.zep Line 273 in 634e723
should be: cookie->setHttpOnly(httpOnly);
cookie->setOptions(options); |
@michalzielanski Could you please submit PR pointing to |
zsilbi
added a commit
to zsilbi/cphalcon
that referenced
this issue
Sep 10, 2020
zsilbi
added a commit
to zsilbi/cphalcon
that referenced
this issue
Sep 10, 2020
zsilbi
added a commit
to zsilbi/cphalcon
that referenced
this issue
Sep 11, 2020
zsilbi
added a commit
to zsilbi/cphalcon
that referenced
this issue
Sep 11, 2020
zsilbi
added a commit
to zsilbi/cphalcon
that referenced
this issue
Sep 11, 2020
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
$this->cookies->set('userinfo',abc,time()+604800,'/',true,null,true,['samesite'=>'None']);
// not effect. with options array
$this->cookies->get('userinfo')->setOptions(['samesite'=>'None']);
//need setOptions again to fix samesite.
The text was updated successfully, but these errors were encountered: