Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Cookie samesite not effect #15129

Closed
arlonlove opened this issue Aug 7, 2020 · 3 comments · Fixed by #15150
Closed

[BUG]: Cookie samesite not effect #15129

arlonlove opened this issue Aug 7, 2020 · 3 comments · Fixed by #15150
Assignees
Labels
bug A bug report

Comments

@arlonlove
Copy link

$this->cookies->set('userinfo',abc,time()+604800,'/',true,null,true,['samesite'=>'None']);
// not effect. with options array

$this->cookies->get('userinfo')->setOptions(['samesite'=>'None']);
//need setOptions again to fix samesite.

@arlonlove arlonlove added bug A bug report status: unverified Unverified labels Aug 7, 2020
@Jeckerson
Copy link
Member

How do you declare cookies service?

@michalzielanski
Copy link

michalzielanski commented Sep 3, 2020

here is bug:

[name, value, expire, path, secure, domain, httpOnly]

should be:

[name, value, expire, path, secure, domain, httpOnly, options]

and here:

cookie->setHttpOnly(httpOnly);

should be:

cookie->setHttpOnly(httpOnly);
cookie->setOptions(options);

@Jeckerson
Copy link
Member

@michalzielanski Could you please submit PR pointing to 4.1.x branch?

@zsilbi zsilbi added 4.1.0 and removed status: unverified Unverified labels Sep 10, 2020
@zsilbi zsilbi self-assigned this Sep 10, 2020
zsilbi added a commit to zsilbi/cphalcon that referenced this issue Sep 10, 2020
zsilbi added a commit to zsilbi/cphalcon that referenced this issue Sep 10, 2020
zsilbi added a commit to zsilbi/cphalcon that referenced this issue Sep 11, 2020
zsilbi added a commit to zsilbi/cphalcon that referenced this issue Sep 11, 2020
zsilbi added a commit to zsilbi/cphalcon that referenced this issue Sep 11, 2020
@zsilbi zsilbi linked a pull request Sep 11, 2020 that will close this issue
4 tasks
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants