feat: workaround for missing Logger messages (attempt 3) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzuy
commented
Feb 11, 2025
grzuy
force-pushed
the
logger-messages-3
branch
from
7430d54 to
0fae412
Compare
grzuy
commented
Feb 11, 2025
| reason: "[critical] Critical!", | ||
| occurrences: [_] | ||
| } | ||
| ] = TestApp.Repo.all(ErrorTracker.Error) |> TestApp.Repo.preload(:occurrences) |
There was a problem hiding this comment.
This tests that both messages are treated as separate errors (with different fingerprints) and not different occurrences of the same error.
There was a problem hiding this comment.
This assertion is flaky with tower 0.7
|
yeah this is nice. the errors group very well now. as far as my app spews them anyway. |
Thanks for testing it 💯 |
|
LGTM |
marpo60
approved these changes
Feb 11, 2025
grzuy
force-pushed
the
logger-messages-3
branch
from
e620855 to
b5cefad
Compare
|
released in v0.3.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #43
alternative to #46