feat: workaround for missing Logger messages (attempt 2) #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so i'm running this branch and with if you're still thinking if you want to incorporate this into master or not - please do. i don't care if you turn it off by default (but i don't see why you would), definitely include it. |
|
3rd attempt: #47 |
grzuy
commented
Feb 11, 2025
| @@ -19,6 +19,13 @@ defmodule TowerErrorTracker.Reporter do | |||
| :ok | |||
| end | |||
|
|
|||
| def report_event(%Tower.Event{kind: :message, reason: reason, level: level} = event) do | |||
| message = "[#{level}] #{reason}" | |||
| ErrorTracker.report({"message #{:erlang.phash2(message)}", message}, [], context(event)) | |||
There was a problem hiding this comment.
3rd attempt (#47), trying to disambiguate messages with source location and function instead of message phash
There was a problem hiding this comment.
yeah i was just coming back to report on this. you're way ahead of me.
|
Going with #47 for now. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #43
alternative to #44 to fix #44 (comment)