Fix TextInput interfering with Japanese conversion #1358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
The bug happened anywhere we set a onChangeText event handler on TextInput, and rewrite the inflight text such as shown in
https://github.com/microsoft/react-native-macos/blob/main/packages/rn-tester/js/examples/TextInput/TextInputSharedExamples.js#L137
To fix we have to ignore changes to text if we have incomplete conversions.
Changelog
[macOS] [Fixed] - Fix TextInput interfering with Japanese conversion
Test Plan
Go to macOS Preferences > Keyboard > Input Sources > add "Japanese Romaji". Use traditional conversion per https://support.apple.com/guide/japanese-input-method/enter-japanese-text-jpim10265/mac.
In the textInput type "watashi", select first auto complete option (e.g. press SPACE), then type "tachi", and confirm you get "私たち":
Before
私阿知
Screen.Recording.2022-08-11.at.3.54.41.PM.mov
After
私たち
after.mov