Textinput range fix #1296
Merged
Textinput range fix #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrieshin
approved these changes
Jul 27, 2022
chiuam
added a commit
to chiuam/react-native-macos
that referenced
this pull request
Jul 27, 2022
chiuam
added a commit
to chiuam/react-native-macos
that referenced
this pull request
Jul 27, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This change addresses #1295. We call
charactersIgnoringModifiersto decode the incoming keyboard event and it returns an empty string for some special characters. Let's add a check to catch that to avoid getting the "index out of bound" error.Changelog
[macOS] [Fixed] - Add string check for special characters
Test Plan
Rerun the repro steps, error message no longer appears in the console.