Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xid/sxid): optimize state reason and error #438

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

cardyok
Copy link
Collaborator

@cardyok cardyok commented Feb 19, 2025

No description provided.

@eahydra
Copy link
Collaborator

eahydra commented Feb 19, 2025

test failed, please fix it.

// sxid
--- FAIL: TestStateUpdateBasedOnEvents (0.00s)
    --- PASS: TestStateUpdateBasedOnEvents/no_event_found (0.00s)
    --- FAIL: TestStateUpdateBasedOnEvents/critical_sxid (0.00s)
    --- FAIL: TestStateUpdateBasedOnEvents/fatal_xid (0.00s)

// xid
--- FAIL: TestStateUpdateBasedOnEvents (0.00s)
    --- PASS: TestStateUpdateBasedOnEvents/no_event_found (0.00s)
    --- FAIL: TestStateUpdateBasedOnEvents/critical_xid (0.00s)
    --- FAIL: TestStateUpdateBasedOnEvents/fatal_xid (0.00s)

BTW #391 aims to improve the component healthy message format in our dashboard...

@cardyok cardyok force-pushed the optimize-xid-suggestion branch from 5713d19 to 9101abf Compare February 19, 2025 05:12
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.46%. Comparing base (dc9c1be) to head (9101abf).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
- Coverage   24.51%   24.46%   -0.06%     
==========================================
  Files         279      279              
  Lines       25276    25278       +2     
==========================================
- Hits         6196     6183      -13     
- Misses      18484    18496      +12     
- Partials      596      599       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gyuho gyuho added this to the v0.4.4 milestone Feb 19, 2025
Copy link
Collaborator

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cardyok cardyok merged commit 93dc6d6 into main Feb 19, 2025
14 of 15 checks passed
@gyuho gyuho deleted the optimize-xid-suggestion branch March 13, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants