Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve XID/SXID suggest action #391

Open
eahydra opened this issue Feb 11, 2025 · 2 comments
Open

Improve XID/SXID suggest action #391

eahydra opened this issue Feb 11, 2025 · 2 comments
Assignees
Milestone

Comments

@eahydra
Copy link
Collaborator

eahydra commented Feb 11, 2025

Some XID/SXID issues have two actions. For example, XID 94:

RepairActions: []common.RepairActionType{
common.RepairActionTypeRebootSystem,
common.RepairActionTypeIgnoreNoActionRequired,
},

We should improve the XID/SXID-related suggested actions to help users resolve issues more effectively.

  1. Only provide one suggestion based on the current state. For example, when we first encounter XID 94, we should suggest that the user reboot the system. If XID 94 persists after two reboots, we should then suggest a HARDWARE_INSPECTION.
  2. In my opinion, we have collected too many references to help users understand what XID/SXID is, even though users may not fully understand them. Perhaps we should reduce these references?
@gyuho
Copy link
Collaborator

gyuho commented Feb 18, 2025

Related discussion: #432 (comment)

@gyuho
Copy link
Collaborator

gyuho commented Feb 18, 2025

if lastXidErr == nil {
reason = "XIDComponent is healthy"
} else {
xidErrBytes, _ := lastXidErr.JSON()
reason = string(xidErrBytes)
stateError = fmt.Sprintf("xid %d detected by %s", lastXidErr.Xid, lastXidErr.DataSource)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants