Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dmesg): remove component, use match func diagnose/scan #432

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Feb 17, 2025

Signed-off-by: Gyuho Lee [email protected]

@gyuho gyuho added this to the v0.4.4 milestone Feb 17, 2025
@gyuho gyuho self-assigned this Feb 17, 2025
@gyuho gyuho added the wip - do not merge working in progress label Feb 17, 2025
@gyuho gyuho force-pushed the remove-dmesg-components branch from 05da703 to 3905115 Compare February 17, 2025 06:52
@gyuho gyuho force-pushed the remove-dmesg-components branch from 3905115 to 08170ad Compare February 17, 2025 11:16
@gyuho gyuho removed the wip - do not merge working in progress label Feb 17, 2025
@gyuho gyuho changed the title feat(dmesg): remove "dmesg" component in favor of independent dmesg watchers feat(dmesg): remove "dmesg" component (use independent dmesg watchers), move dmesg xid/sxid to components Feb 17, 2025
@gyuho gyuho force-pushed the remove-dmesg-components branch from 08170ad to 850a419 Compare February 17, 2025 12:57
@gyuho gyuho changed the title feat(dmesg): remove "dmesg" component (use independent dmesg watchers), move dmesg xid/sxid to components feat(dmesg): remove component, use match func diagnose/scan Feb 18, 2025
@gyuho gyuho force-pushed the remove-dmesg-components branch from 2a9a668 to 835a803 Compare February 18, 2025 12:24
@leptonai leptonai deleted a comment from codecov bot Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 1.63934% with 60 lines in your changes missing coverage. Please review.

Project coverage is 24.50%. Comparing base (f30fdd4) to head (835a803).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/diagnose/diagnose.go 2.63% 36 Missing and 1 partial ⚠️
pkg/diagnose/scan.go 0.00% 21 Missing ⚠️
pkg/config/default.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   24.19%   24.50%   +0.30%     
==========================================
  Files         287      279       -8     
  Lines       25870    25436     -434     
==========================================
- Hits         6259     6232      -27     
+ Misses      19007    18604     -403     
+ Partials      604      600       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gyuho gyuho merged commit 0092ec5 into main Feb 18, 2025
14 of 15 checks passed
@gyuho gyuho deleted the remove-dmesg-components branch February 18, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants