Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigo.generate includes hash #87

Closed
Nyholm opened this issue Mar 21, 2017 · 3 comments
Closed

Navigo.generate includes hash #87

Nyholm opened this issue Mar 21, 2017 · 3 comments

Comments

@Nyholm
Copy link
Contributor

Nyholm commented Mar 21, 2017

If one is using hashes the router.generate('foo') will include the hash.

This means that:

router.navigate(router.generate('foo'));
// Navigates to `#url` which will be "www.example.com/##url"

Im not sure what the best solution is here. Either we remove the hash from generate or we make sure to trim it in navigate.

krasimir pushed a commit that referenced this issue Mar 24, 2017
@krasimir
Copy link
Owner

Just released 4.3.3 that contains a fix for this issue.

@Nyholm
Copy link
Contributor Author

Nyholm commented Mar 25, 2017

Thank you. But please use PRs. That will mean I have a change to review your code.

@krasimir
Copy link
Owner

@Nyholm that's a very good point 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants