Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the -Wmacro-redefined warning. #749

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

markww
Copy link
Contributor

@markww markww commented Sep 30, 2022

Currently, the fuzztest library has an issue where two macros with colliding names are leaked from the headers of absl and re2 into one of fuzztest's .cc files
( google/fuzztest#41 ). Once this issue is fixed, we should re-enable this warning.

@markww markww force-pushed the disable_macro_redefined@winterrowd branch from 922f336 to 67c5428 Compare September 30, 2022 22:30
Copy link
Collaborator

@bgogul bgogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo typo.

Currently, the fuzztest library has an issue where two macros with
colliding names are leaked from the headers of `absl` and `re2` into one
of fuzztest's `.cc` files
( google/fuzztest#41 ). Once this issue is
fixed, we should re-enable this warning.
@markww markww force-pushed the disable_macro_redefined@winterrowd branch from 67c5428 to 87a7b6e Compare September 30, 2022 23:54
@markww markww merged commit 3431afe into main Oct 3, 2022
@markww markww deleted the disable_macro_redefined@winterrowd branch October 3, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants