Skip to content

Commit

Permalink
Disable the -Wmacro-redefined warning. (#749)
Browse files Browse the repository at this point in the history
Currently, the fuzztest library has an issue where two macros with
colliding names are leaked from the headers of `absl` and `re2` into one
of fuzztest's `.cc` files
( google/fuzztest#41 ). Once this issue is
fixed, we should re-enable this warning.
  • Loading branch information
Mark Winterrowd authored Oct 3, 2022
1 parent 44235b9 commit 3431afe
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ build --cxxopt='-Werror' --cxxopt='-Wall'
# are not directly responsible.
build --features=external_include_paths
build --cxxopt='-Wno-deprecated-declarations'

# Why are we doing this when Souffle-generated C++ clearly uses exceptions?
# Well, Google famously does not like C++ exceptions in its internal codebase,
# so we will need to explicitly override that in Raksha files everywhere we
Expand All @@ -30,6 +31,12 @@ build --host_cxxopt='-Wno-deprecated-declarations'
# is our attempt to work around that.
build --cxxopt='-Wno-unknown-warning-option'
build --host_cxxopt='-Wno-unknown-warning-option'
# The fuzztest library also has a conflict in one of its `.cc` files in
# a macro. When https://github.com/google/fuzztest/issues/41 is fixed, we
# should re-enable this warning.
build --cxxopt='-Wno-macro-redefined'
build --host_cxxopt='-Wno-macro-redefined'

# Similarly, we should not set this flag that we're using as a debugging
# assistant when compiling third party libraries.
# build --host_cxxopt='-fno-exceptions'
Expand Down

0 comments on commit 3431afe

Please sign in to comment.