fix: replace LDK trusted 0-anchor reserve peers with 0 per channel reserve #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
requested review from
bumi,
frnandu,
MoritzKa,
im-adithya and
reneaaron
MoritzKa
reviewed
Feb 6, 2025
MoritzKa
reviewed
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1065
This PR stops requiring all users to trust the LSPs to correctly return the correct amount on channel closure (which when channels are closed due to stuck payments they do not), and instead allow the user to choose whether or not they will protect themselves or trust the counterparty. It introduces one extra warning icon to the UI but I think this is important for users to understand.
Tests in mutinynet: