Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PerChannelReserveSats rather than TrustedPeersNoReserve #1065

Closed
rolznz opened this issue Feb 5, 2025 · 0 comments · Fixed by #1069
Closed

Set PerChannelReserveSats rather than TrustedPeersNoReserve #1065

rolznz opened this issue Feb 5, 2025 · 0 comments · Fixed by #1069
Assignees
Milestone

Comments

@rolznz
Copy link
Contributor

rolznz commented Feb 5, 2025

After a channel is closed with stuck HTLCs, Alby Hub will not try to claim contestable funds since it trusts the LSP. This means we need to actively contact the LSP for a refund.

We can do a middle ground by instead of keeping a list of TrustedPeersNoReserve we can set the PerChannelReserveSats to 0. This should still allow channels to be made with 0 on-chain balance, but if the user does have some on-chain balance, they can spend it to ensure their funds are returned to them. It's not perfect because the user might not have on-chain funds. But it should be a bit better than now.

@rolznz rolznz added this to the v1.15.0 milestone Feb 5, 2025
@rolznz rolznz self-assigned this Feb 5, 2025
@rolznz rolznz modified the milestones: v1.15.0, v.1.14.0 Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant