Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move ingress manager metrics to a separate file #4454

Merged
merged 6 commits into from
Mar 24, 2025

Conversation

kpop-dfinity
Copy link
Contributor

@kpop-dfinity kpop-dfinity commented Mar 21, 2025

Also cleaned up bazel/cargo dependencies + some other tiny things I noticed while scanning the code

@kpop-dfinity kpop-dfinity requested a review from gbrel March 21, 2025 10:51
@kpop-dfinity kpop-dfinity marked this pull request as ready for review March 21, 2025 10:51
@kpop-dfinity kpop-dfinity requested a review from a team as a code owner March 21, 2025 10:51
Copy link
Contributor

@gbrel gbrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@kpop-dfinity kpop-dfinity added this pull request to the merge queue Mar 24, 2025
Merged via the queue into master with commit 7e78d5c Mar 24, 2025
21 checks passed
@kpop-dfinity kpop-dfinity deleted the kpop/refactor/move_ingress_metrics branch March 24, 2025 08:51
aterga pushed a commit that referenced this pull request Mar 24, 2025
Also cleaned up bazel/cargo dependencies + some other tiny things I
noticed while scanning the code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants