Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce a couple of new metrics to the ingress manager #4455

Merged
merged 10 commits into from
Mar 24, 2025

Conversation

kpop-dfinity
Copy link
Contributor

@kpop-dfinity kpop-dfinity commented Mar 21, 2025

Also renamed one of the errors to better match its intent

@github-actions github-actions bot added the chore label Mar 21, 2025
Copy link
Contributor

@derlerd-dfinity derlerd-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

Base automatically changed from kpop/refactor/move_ingress_metrics to master March 24, 2025 08:51
@kpop-dfinity kpop-dfinity marked this pull request as ready for review March 24, 2025 08:57
@kpop-dfinity kpop-dfinity requested a review from a team as a code owner March 24, 2025 08:57
@kpop-dfinity kpop-dfinity requested a review from gbrel March 24, 2025 09:54
Copy link
Contributor

@gbrel gbrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@kpop-dfinity kpop-dfinity added this pull request to the merge queue Mar 24, 2025
@kpop-dfinity
Copy link
Contributor Author

Thank you for the review!

Merged via the queue into master with commit 6c830bd Mar 24, 2025
21 checks passed
@kpop-dfinity kpop-dfinity deleted the kpop/more_ingress_metrics branch March 24, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants