-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] updating life cycle of dandiset #275
base: master
Are you sure you want to change the base?
Conversation
…i updates (not sure if we should always run the etst, so for now I added skip); updates to to_datacite function
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 97.54% 89.33% -8.22%
==========================================
Files 16 16
Lines 1753 1819 +66
==========================================
- Hits 1710 1625 -85
- Misses 43 194 +151
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I left minor comments/wishes
"assetsSummary": { | ||
"schemaKey": "AssetsSummary", | ||
"numberOfBytes": 10, | ||
"numberOfFiles": 1, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hopefully does not matter but whenever dandiset is created, there is no assets summary yet -- it is done async IIRC, hence
"assetsSummary": { | |
"schemaKey": "AssetsSummary", | |
"numberOfBytes": 10, | |
"numberOfFiles": 1, | |
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assetsSummary
is a mandatory field for Dandiset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in dandi archive we do following if not provided in metadata
if 'assetsSummary' not in metadata:
metadata['assetsSummary'] = {
'schemaKey': 'AssetsSummary',
'numberOfBytes': 0,
'numberOfFiles': 0,
}
http://github.com/dandi/dandi-archive/blob/HEAD/dandiapi/api/models/version.py
to_datacite
function, so it can also work fordraft