Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: use "-" instead of "." in snippets #812

Merged
merged 2 commits into from Apr 11, 2023
Merged

Bugfix: use "-" instead of "." in snippets #812

merged 2 commits into from Apr 11, 2023

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

Addresses this comment.

@Shane-XB-Qian

@Shane-XB-Qian
Copy link
Contributor

thx, this looks good.

// though lsp client to recognize [[ ]] may still had issues, but that maybe not a problem from this.

@Shane-XB-Qian
Copy link
Contributor

well, looks i found the reason, though i am not sure which the real one caused it.
but for example if-else-test, you set 'if [[ $${1:variable} ${2|-ef,-nt,-ot,==,=~,!=,<,>,-lt,-le,-gt,-ge|} $${3:variable} ]]; then',
those two $$ maybe convenience in some cases, but to shell or to snip plugin, $ is a special meaning char....

so if you can or make it be simple,
i wish you could remove that double $$, but just one $,
user can manually input the $ for var, Besides that actually Not always a var but a const string/number etc.

@EmilyGraceSeville7cf
Copy link
Contributor Author

Thanks for feedback. Gonna fix this issue today.

@skovhus skovhus merged commit a1f96dc into bash-lsp:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants