Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippets update: add more snippets and change their naming convention #805

Merged
merged 19 commits into from Apr 2, 2023
Merged

Snippets update: add more snippets and change their naming convention #805

merged 19 commits into from Apr 2, 2023

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Mar 30, 2023

  • document all snippets via documentation
  • add snippets for commands like if with [[ command
  • add more sed and awk snippets
  • change naming convention to make labels more descriptive (but longer)
  • add snippet for function doc (closes Add snippet for documenting functions (I will implement) #781)
  • snippets for jq, yq

@EmilyGraceSeville7cf
Copy link
Contributor Author

@skovhus, what to do with these failures?

@skovhus skovhus merged commit 20c1b14 into bash-lsp:main Apr 2, 2023
@Shane-XB-Qian
Copy link
Contributor

@EmilySeville7cfg
those if-else.test and while.test was verified and worked at your side?

@EmilyGraceSeville7cf
Copy link
Contributor Author

@Shane-XB-Qian, yep. ;) I've checked them.

@Shane-XB-Qian
Copy link
Contributor

Shane-XB-Qian commented Apr 4, 2023

@EmilySeville7cfg
would you mind change those - and . delimiters in if-else.test (uniformed) to _, e.g 'if_else_test` ?

or at least Not use . in its label.

maybe that's not a problem in vscode, but in vim, normally - and . was not a keyword char, but maybe a trigger char.
maybe i can make that - work at my side, though buggy still.

@EmilyGraceSeville7cf
Copy link
Contributor Author

would you mind change those - and . delimiters in if-else.test (uniformed) to _, e.g 'if_else_test` ?

I can change it to - for now. Hoply send PR today or tomorrow to fix this issue. Didn't know about such problem with Vim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add snippet for documenting functions (I will implement)
3 participants