Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ShellCheck config #571

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Fix ShellCheck config #571

merged 3 commits into from
Nov 28, 2022

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented Nov 28, 2022

Solves #570

#555 #563 introduced an unwanted side effect that you cannot disable ShellCheck from the configuration.

So we have a few different use cases here:

  1. being able to disable shellcheck linting
  2. being able to provide a custom path for shellcheck
  3. default behaviour of the shellcheck integration working if shellcheck is found on the path

Defaulting the configuration to "shellcheck" and making an empty string disable it solves the different needs.

And we don't need the which library as the ShellCheck integration will just try linting once using the provided executable – if it fails we don't lint again.

So we have a few different use cases here:
1) being able to disable shellcheck linting
2) being able to provide a custom path for shellcheck
3) default behaviour of the shellcheck integration working if shellcheck is found on the path

Defaulting to "shellcheck" and making an empty string disable it solves all of them.
@skovhus skovhus changed the title ShellCheck config fixed. Fix ShellCheck config Nov 28, 2022
@skovhus skovhus changed the title Fix ShellCheck config Fix ShellCheck config and release version 3.3.0 Nov 28, 2022
@skovhus skovhus force-pushed the shellcheck-config-v2 branch from 6ac0602 to 11a39c9 Compare November 28, 2022 09:33
@skovhus skovhus changed the title Fix ShellCheck config and release version 3.3.0 Fix ShellCheck config Nov 28, 2022
@skovhus skovhus merged commit 3736fe8 into main Nov 28, 2022
@skovhus skovhus deleted the shellcheck-config-v2 branch November 28, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant