Fix ShellCheck config #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we have a few different use cases here: 1) being able to disable shellcheck linting 2) being able to provide a custom path for shellcheck 3) default behaviour of the shellcheck integration working if shellcheck is found on the path Defaulting to "shellcheck" and making an empty string disable it solves all of them.
skovhus
changed the title
skovhus
force-pushed
the
shellcheck-config-v2
branch
from
6ac0602 to
11a39c9
Compare
skovhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #570
#555 #563 introduced an unwanted side effect that you cannot disable ShellCheck from the configuration.
So we have a few different use cases here:
Defaulting the configuration to "shellcheck" and making an empty string disable it solves the different needs.
And we don't need the
whichlibrary as the ShellCheck integration will just try linting once using the provided executable – if it fails we don't lint again.