Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shellcheck: fix vscode config and default to executable found on path #555

Merged
merged 4 commits into from
Nov 25, 2022

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented Nov 25, 2022

Fixes #554

@skovhus skovhus changed the title shellcheck: fix vscode configuration and default to executable found on path shellcheck: fix vscode config and default to executable found on path Nov 25, 2022
@skovhus skovhus marked this pull request as ready for review November 25, 2022 08:53
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #555 (54a8774) into main (5cebe10) will decrease coverage by 0.17%.
The diff coverage is 69.23%.

❗ Current head 54a8774 differs from pull request most recent head c1dac4f. Consider uploading reports for the commit c1dac4f to get more accurate results

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   74.55%   74.37%   -0.18%     
==========================================
  Files          19       19              
  Lines         668      679      +11     
  Branches      118      120       +2     
==========================================
+ Hits          498      505       +7     
- Misses        154      158       +4     
  Partials       16       16              
Impacted Files Coverage Δ
server/src/util/sh.ts 88.46% <ø> (ø)
server/src/linter.ts 86.07% <63.63%> (-3.78%) ⬇️
server/src/server.ts 58.76% <100.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@skovhus skovhus enabled auto-merge November 25, 2022 09:00
@skovhus skovhus merged commit 44539cb into main Nov 25, 2022
@skovhus skovhus deleted the fix-shellcheck branch November 25, 2022 09:01
@skovhus skovhus mentioned this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bash IDE (VSCode) doesn't work on macOS
1 participant