Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teleport modals early using JS observer #2257

Merged
merged 13 commits into from
Feb 18, 2025
Merged

Teleport modals early using JS observer #2257

merged 13 commits into from
Feb 18, 2025

Conversation

mvorisek
Copy link
Member

fix #2151
fix #2246

@mvorisek mvorisek changed the title Teleport using observer Teleport modal element using observer Feb 18, 2025
@mvorisek mvorisek added the MAJOR label Feb 18, 2025
@mvorisek mvorisek changed the title Teleport modal element using observer Teleport modals using JS observer Feb 18, 2025
@mvorisek mvorisek marked this pull request as ready for review February 18, 2025 17:18
@mvorisek mvorisek changed the title Teleport modals using JS observer Teleport modals early using JS observer Feb 18, 2025
@mvorisek mvorisek merged commit 9b8117b into develop Feb 18, 2025
51 checks passed
@mvorisek mvorisek deleted the teleport_early branch February 18, 2025 18:22
This was referenced Feb 19, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
MAJOR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modal in not teleported on "html reload" Teleport modal early
1 participant
@mvorisek