Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teleport modal early #2151

Closed
mvorisek opened this issue Jan 31, 2024 · 1 comment · Fixed by #2257
Closed

Teleport modal early #2151

mvorisek opened this issue Jan 31, 2024 · 1 comment · Fixed by #2257

Comments

@mvorisek
Copy link
Member

Improve #2142 and teleport modal (and right panel) at the page load and then on any DOM update (via our JS) immediately.

It should be done recursively as the response is not guaranteed to not contain nested modal placeholders.

Also we can then load the modal early to improve #2143 UX.

@mvorisek
Copy link
Member Author

mvorisek commented Jan 31, 2025

After #2244 there should be no https://github.com/atk4/ui/blob/4f4729bd25/js/src/Helper/elementRemoveObserver.js#L76 warning emit within all tests - such warning/usecase is dangerous as "remove handler" is triggered which may abort some async handlers like outgoing API connection.

Can be reproduced on /demos/data-action/jsactionsgrid.php demo with "Edit ISO3".

Image

(1st and (repeated) 2nd click)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant