Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate async JS handlers when DOM owner is destroyed #2244

Merged
merged 21 commits into from
Feb 7, 2025
Merged

Conversation

mvorisek
Copy link
Member

fix #393

All DOM element related async callbacks must be terminated/removed before the element is removed/replaced.

@mvorisek mvorisek added the MAJOR label Jan 29, 2025
@mvorisek mvorisek force-pushed the view_unload branch 2 times, most recently from c744b0e to 0702fcf Compare January 29, 2025 10:24
@mvorisek mvorisek changed the title Observe DOM elements removal Add support for "DOM element remove" events Jan 29, 2025
@mvorisek mvorisek force-pushed the view_unload branch 6 times, most recently from bc27df9 to d2c8800 Compare January 30, 2025 16:51
@mvorisek mvorisek changed the title Add support for "DOM element remove" events Abort async JS handlers when source element is destroyed Jan 30, 2025
@mvorisek mvorisek force-pushed the view_unload branch 3 times, most recently from aaab7d4 to 5143d3c Compare January 30, 2025 23:33
@mvorisek mvorisek changed the title Abort async JS handlers when source element is destroyed Terminate async JS handlers when source element is destroyed Jan 30, 2025
@mvorisek mvorisek changed the title Terminate async JS handlers when source element is destroyed Terminate async JS handlers when DOM owner is destroyed Jan 30, 2025
@mvorisek mvorisek marked this pull request as ready for review January 31, 2025 00:25
@mvorisek mvorisek mentioned this pull request Jan 31, 2025
@mvorisek mvorisek force-pushed the view_unload branch 4 times, most recently from c8ae061 to 8378c91 Compare February 2, 2025 21:58
@mvorisek mvorisek marked this pull request as draft February 3, 2025 11:03
@mvorisek mvorisek marked this pull request as ready for review February 6, 2025 00:34
@mvorisek mvorisek merged commit 8a359e0 into develop Feb 7, 2025
51 checks passed
@mvorisek mvorisek deleted the view_unload branch February 7, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Reload must unload/stop old JS
1 participant