-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comonadic comprehensions #91
Conversation
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
============================================
+ Coverage 43.87% 47.05% +3.17%
- Complexity 113 120 +7
============================================
Files 54 58 +4
Lines 800 831 +31
Branches 130 131 +1
============================================
+ Hits 351 391 +40
+ Misses 399 390 -9
Partials 50 50
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome!, but some of the names are confusing IMO
|
||
suspend fun <B> HK<F, B>.bind(): B = bind { this } | ||
|
||
suspend fun <B> bind(m: () -> HK<F, B>): B = suspendCoroutineOrReturn { c -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is bind
a good name for this? bind has the semantics of flatMap, whereas this is 'extract'. what about cobind
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be extract then. Fixed!
* arrow-kt#85: Add Enum encoder and decoder * arrow-kt#85: Add Enum test * arrow-kt#85: Add negative tests for enum decoder * arrow-kt#85: Clean up test names and move the enum code to the correct package * move enum instances to its companion object * arrow-kt#85: Add enum section to docs * arrow-kt#85: Docs formatting * arrow-kt#85: Combine enum docs fragments * arrow-kt#85: Import helios.instances.* * arrow-kt#85: Silence Ank * arrow-kt#85: Split up section on Enum * arrow-kt#85: Fix Enum decoder return type * Update docs/docs/coding/README.md Co-Authored-By: Adrian Ramirez Fornell <[email protected]>
* Disconnect arrow-optics-mtl and comment tests * Include back arrow-optics-mtl and move commented tests from arrow-optics to arrow-optics-mtl * Disconnect arrow-optics-mtl * Remove arrow-optics-mtl from arrow-docs * Add arrow-optics to arrow-docs and remove arrow-optics-mtl docs * Move arrow-optics-mtl docs to arrow-optics-mtl module * Remove commented tests already moved to correspondent module * Remove incubator modules from arrow-docs * Remove examples making use of incubator modules * Remove macros
Closes #88