Add implementation of WriterT and WriterTMonad #85

pakoito · 2017-04-29T12:29:31Z

Closes #84

pakoito · 2017-04-29T12:31:25Z

Missing: tests. Do not merge yet.

…ption. Add Semigroup instances for NonEmptyList and Number. Add tests for WriterT. Add tests for NumberSemiGroup, OptionMonoid, and NonEmptyListSemiGroup.

pakoito · 2017-04-29T14:44:49Z

I went overboard and fixed the Monoid and Semigroup instances.

jrgonzalezg · 2017-04-29T14:52:15Z

katz/src/main/kotlin/katz/instances/NonEmptyListSemigroup.kt

+
+class NonEmptyListSemigroup<A> : Semigroup<NonEmptyList<A>> {
+    override fun combine(a: NonEmptyList<A>, b: NonEmptyList<A>): NonEmptyList<A> =
+            NonEmptyList.fromListUnsafe(a.all + b.all)


This is the same as just a + b

No, the compiler won't pick it up for whatever reason :D

Committed a fix :)

…rly used as they were. Disabled detekt removing Unit return types since it caused the build to fail. Re-applied detekt and fixed formatting.

codecov · 2017-04-29T15:40:35Z

Codecov Report

❗ No coverage uploaded for pull request base (master@ca20458). Click here to learn what that means.
The diff coverage is 55.55%.

@@            Coverage Diff            @@
##             master      #85   +/-   ##
=========================================
  Coverage          ?   43.35%           
  Complexity        ?      104           
=========================================
  Files             ?       51           
  Lines             ?      775           
  Branches          ?      130           
=========================================
  Hits              ?      336           
  Misses            ?      391           
  Partials          ?       48

Impacted Files	Coverage Δ	Complexity Δ
katz/src/main/kotlin/katz/instances/ListMonoid.kt	`0% <ø> (ø)`	`0 <0> (?)`
katz/src/main/kotlin/katz/instances/FloatMonoid.kt	`0% <0%> (ø)`	`0 <0> (?)`
...atz/src/main/kotlin/katz/instances/DoubleMonoid.kt	`0% <0%> (ø)`	`0 <0> (?)`
katz/src/main/kotlin/katz/instances/ByteMonoid.kt	`0% <0%> (ø)`	`0 <0> (?)`
katz/src/main/kotlin/katz/instances/LongMonoid.kt	`0% <0%> (ø)`	`0 <0> (?)`
katz/src/main/kotlin/katz/instances/ShortMonoid.kt	`0% <0%> (ø)`	`0 <0> (?)`
...rc/main/kotlin/katz/instances/NonEmptyListMonad.kt	`80% <0%> (ø)`	`0 <0> (?)`
katz/src/main/kotlin/katz/instances/IntMonoid.kt	`100% <100%> (ø)`	`2 <2> (?)`
...ain/kotlin/katz/instances/NonEmptyListSemigroup.kt	`100% <100%> (ø)`	`1 <1> (?)`
.../src/main/kotlin/katz/instances/NumberSemigroup.kt	`100% <100%> (ø)`	`1 <1> (?)`
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca20458...64e33f3. Read the comment docs.

raulraja

We should add also MonadWriter and the rest of the MTL style popular typeclasses

raulraja · 2017-05-04T21:39:09Z

katz/src/main/kotlin/katz/typeclasses/Applicative.kt

@@ -20,7 +20,9 @@ interface Applicative<F> : Functor<F>, Typeclass {
            fb.map { fb -> map2(fa, fb, f) }
 }

-data class Tuple2<out A, out B>(val a: A, val b: B)
+data class Tuple2<out A, out B>(val a: A, val b: B) {
+    fun swap(): Tuple2<B, A> = Tuple2(b, a)


what if we call this reverse and implement it in all Tuple*?

raulraja · 2017-05-04T21:41:37Z

katz/src/main/kotlin/katz/typeclasses/Applicative.kt

@@ -30,6 +32,10 @@ data class Tuple8<out A, out B, out C, out D, out E, out F, out G, out H>(val a:
 data class Tuple9<out A, out B, out C, out D, out E, out F, out G, out H, out I>(val a: A, val b: B, val c: C, val d: D, val e: E, val f: F, val g: G, val h: H, val i: I)
 data class Tuple10<out A, out B, out C, out D, out E, out F, out G, out H, out I, out J>(val a: A, val b: B, val c: C, val d: D, val e: E, val f: F, val g: G, val h: H, val i: I, val j: J)

+infix fun <A, B, C, D> Tuple3<A, B, C>.toT(d: D): Tuple4<A, B, C, D> = Tuple4(this.a, this.b, this.c, d)


Should this be plus? Also wondering what a Semigroup instance for each of the tuples looks like ;)

* arrow-kt#85: Add Enum encoder and decoder * arrow-kt#85: Add Enum test * arrow-kt#85: Add negative tests for enum decoder * arrow-kt#85: Clean up test names and move the enum code to the correct package * move enum instances to its companion object * arrow-kt#85: Add enum section to docs * arrow-kt#85: Docs formatting * arrow-kt#85: Combine enum docs fragments * arrow-kt#85: Import helios.instances.* * arrow-kt#85: Silence Ank * arrow-kt#85: Split up section on Enum * arrow-kt#85: Fix Enum decoder return type * Update docs/docs/coding/README.md Co-Authored-By: Adrian Ramirez Fornell <[email protected]>

* Deprecate extension methods for NonEmptyList * Move NonEmptyList top-level functions to Lens companion * Update tests * Update deprecation message

Add implementation of WriterT and WriterTMonad

8c24e2c

pakoito added the enhancement label Apr 29, 2017

pakoito self-assigned this Apr 29, 2017

pakoito requested review from raulraja, ffgiraldez, aballano and jrgonzalezg April 29, 2017 12:29

Refactor Monoid instances for Int and List. Add Monoid instance for O…

6fb27cf

…ption. Add Semigroup instances for NonEmptyList and Number. Add tests for WriterT. Add tests for NumberSemiGroup, OptionMonoid, and NonEmptyListSemiGroup.

pakoito added 2 commits April 29, 2017 15:49

Add Monoid instances for Float, Double, Long

6232797

Rename test

8ac80c7

jrgonzalezg reviewed Apr 29, 2017

View reviewed changes

pakoito and others added 3 commits April 29, 2017 16:17

Add Byte and Short monoid

06c923f

Fix tests

01ac00c

Improved plus operators on NonEmptyList since they could not be prope…

64e33f3

…rly used as they were. Disabled detekt removing Unit return types since it caused the build to fail. Re-applied detekt and fixed formatting.

raulraja approved these changes May 4, 2017

View reviewed changes

raulraja merged commit 33b77a1 into master May 4, 2017

raulraja deleted the paco-writert branch May 4, 2017 21:42

pakoito mentioned this pull request May 4, 2017

Tweaks to Applicative Tuples #89

Closed

rachelcarmena pushed a commit that referenced this pull request Feb 24, 2021

Deprecate extension methods for NonEmptyList (#85)

cc071fd

* Deprecate extension methods for NonEmptyList * Move NonEmptyList top-level functions to Lens companion * Update tests * Update deprecation message

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add implementation of WriterT and WriterTMonad #85

Add implementation of WriterT and WriterTMonad #85

pakoito commented Apr 29, 2017

pakoito commented Apr 29, 2017 •

edited

Loading

pakoito commented Apr 29, 2017

jrgonzalezg Apr 29, 2017

pakoito Apr 29, 2017 •

edited

Loading

jrgonzalezg Apr 29, 2017

codecov bot commented Apr 29, 2017

raulraja left a comment

raulraja May 4, 2017

raulraja May 4, 2017

Add implementation of WriterT and WriterTMonad #85

Add implementation of WriterT and WriterTMonad #85

Conversation

pakoito commented Apr 29, 2017

pakoito commented Apr 29, 2017 • edited Loading

pakoito commented Apr 29, 2017

jrgonzalezg Apr 29, 2017

Choose a reason for hiding this comment

pakoito Apr 29, 2017 • edited Loading

Choose a reason for hiding this comment

jrgonzalezg Apr 29, 2017

Choose a reason for hiding this comment

codecov bot commented Apr 29, 2017

Codecov Report

raulraja left a comment

Choose a reason for hiding this comment

raulraja May 4, 2017

Choose a reason for hiding this comment

raulraja May 4, 2017

Choose a reason for hiding this comment

pakoito commented Apr 29, 2017 •

edited

Loading

pakoito Apr 29, 2017 •

edited

Loading