Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tagName flag #793

Merged
merged 2 commits into from
Dec 6, 2018
Merged

Support tagName flag #793

merged 2 commits into from
Dec 6, 2018

Conversation

trevor-scheer
Copy link
Member

This PR re-adds support for providing a custom tagName for client:codegen.

Also included:

  • Some addition to types
  • Tests for tagName as a flag and in the config

Fixes: #723

This commit re-adds support for providing a custom tagName.

Also:
1) The tagName is relevant to creation of the GraphQLClientProject and may be
required by more than just codegen so it makes sense to move this flag to the ClientCommand.

2) Added interface for ClientCommandFlags
@jbaxleyiii jbaxleyiii merged commit e4e9522 into master Dec 6, 2018
@jbaxleyiii jbaxleyiii deleted the trevor/fix-tagname branch December 6, 2018 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants