Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagName not being applied when searching documents. #723

Closed
berrigan opened this issue Nov 19, 2018 · 1 comment
Closed

tagName not being applied when searching documents. #723

berrigan opened this issue Nov 19, 2018 · 1 comment
Assignees

Comments

@berrigan
Copy link

It would seem that tagName argument is no longer being applied.

This seems to come from loadAndMergeQueryDocuments (packages/apollo-codegen-core/src/loading.ts) no longer being called in generate (packages/apollo/src/generate.ts).

This can be doubly seen with the tagName parameter to generate no longer being used.

Combined with the regression seen in #706 (comment), it seems impossible to apply document/query searching to a subset of files.

@trevor-scheer
Copy link
Member

Thanks for submitting an issue @berrigan! I'm off through the holiday so no promises as to how soon I can get to this but it's next on my list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants