Allow --no-addTypename in #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milosdanilov
requested review from
jbaxleyiii and
trevor-scheer
as code owners
milosdanilov
force-pushed
the
milosdanilov/allow-no-addTypename
branch
from
73c78fa to
5f9bdab
Compare
trevor-scheer
approved these changes
Nov 28, 2018
There was a problem hiding this comment.
LGTM! @jbaxleyiii looks like that flaky test is back, believe the error was something coming from oclif (one of the plugins IIRC?)
|
@trevor-scheer I think you are correct! @milosdanilov thanks for doing this! |
jbaxleyiii
approved these changes
Nov 30, 2018
|
@JakeDawkins @trevor-scheer I think we should probably move this up to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be able to set --addTypename to false with --no-addTypename in apollo client:codegen command.
Follow up for PR #713
By agreement of @jbaxleyiii
This should resolve Issue #680