Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --no-addTypename in #758

Conversation

milosdanilov
Copy link
Contributor

Should be able to set --addTypename to false with --no-addTypename in apollo client:codegen command.

Follow up for PR #713
By agreement of @jbaxleyiii

This should resolve Issue #680

@milosdanilov milosdanilov force-pushed the milosdanilov/allow-no-addTypename branch from 73c78fa to 5f9bdab Compare November 28, 2018 18:27
Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @jbaxleyiii looks like that flaky test is back, believe the error was something coming from oclif (one of the plugins IIRC?)

@jbaxleyiii
Copy link
Contributor

@trevor-scheer I think you are correct! @milosdanilov thanks for doing this!

@jbaxleyiii
Copy link
Contributor

@JakeDawkins @trevor-scheer I think we should probably move this up to the ClientCommand at some point so the same option is available for client:check / publish, but our current stance of config first for those is the safer route for now.

@jbaxleyiii jbaxleyiii merged commit f4c8d45 into apollographql:master Nov 30, 2018
@milosdanilov milosdanilov deleted the milosdanilov/allow-no-addTypename branch November 30, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants