Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--no-addTypename does not work #680

Closed
artemave opened this issue Nov 9, 2018 · 1 comment
Closed

--no-addTypename does not work #680

artemave opened this issue Nov 9, 2018 · 1 comment
Assignees
@trevor-scheer

Comments

@artemave
Copy link

artemave commented Nov 9, 2018 •
edited
Loading 

$ yarn apollo client:codegen src --target=typescript --no-addTypename
$ /Users/artem/projects/inlens-web/node_modules/.bin/apollo client:codegen src --target=typescript --no-addTypename
 ›   Error: Unexpected argument: --no-addTypename

Looking at the code, the reason appears to be that addTypename flag declaration is missing allowNo: true option (or should not default to true):

image

https://github.com/apollographql/apollo-tooling/blob/master/packages/apollo/src/commands/client/codegen.ts#L47,L50

npm module version: 2.0.9
milosdanilov added a commit to milosdanilov/apollo-tooling that referenced this issue Nov 16, 2018
@milosdanilov
addTypename flag should be false by default (apollographql#680)
381245d 
By following documentation --addTypename argument should be set to false by default
@milosdanilov milosdanilov mentioned this issue Nov 28, 2018
Merged
@trevor-scheer
Copy link
Member

Resolved in #758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevor-scheer trevor-scheer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artemave @trevor-scheer