-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema:download generates incompatible schema JSON #555
Comments
This schema format is also incompatible with apollo-android, which is still internally using the now-deprecated Quick-and-dirty
|
Changing this would also mean changing |
@danilobuerger I am currently using The https://github.com/graphql/graphql-js reference implementation used here makes reference to I believe that it may in fact be the case that the root node should be |
I've resolved the issue discussed here in #562, although I've also noticed that Is this something that should be included in the aforementioned PR? |
@jamesmbourne I merged your PR and that seems like the right fix, but wondering what you mean by:
|
@martijnwalraven Thanks for getting that merged in! I was referring to the |
@jamesmbourne After some discussion, I pushed another change to no longer nest the introspection result under This seems to make more semantic sense, because you'd never want to store a schema with |
Seems happen with iOS too using |
Version
apollo v1.7.0
Description
Running
apollo schema:download
generates JSON which omits the "__schema" root property. This seems to break with convention (e.g. intellij GraphQL plugin, graphql-js introspection tests, relay-starter-kit, spectrum).I am using the intellij GraphQL plugin and it is unfortunately unable to read the output from apollo at the moment.
Steps to reproduce
npm install apollo
npx apollo schema:download schema.json --endpoint=https://graphql-pokemon.now.sh
Expected
The schema.json file should have the root property "__schema"
Actual
The"__schema" property is missing and instead it seems to have been unwrapped so that the root properties are "queryType", "mutationType", etc.
The text was updated successfully, but these errors were encountered: