Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #23]add unit test to increase codeCov #28

Merged
merged 5 commits into from
Mar 14, 2022

Conversation

tianliuliu
Copy link
Contributor

fix #23 mqtt-ds/src/test/java/org/apache/rocketmq/mqtt/ds/test/LmqOffsetStoreManagerTest.java
add unit test for LmqOffsetStoreManagerTest.java to increase the codeCov

@ShannonDing
Copy link
Member

try run “mvn -B clean apache-rat:check” local.

@codecov-commenter
Copy link

Codecov Report

Merging #28 (00a430e) into main (0f2a830) will increase coverage by 1.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   19.84%   21.09%   +1.24%     
==========================================
  Files          87       87              
  Lines        3723     3721       -2     
  Branches      610      610              
==========================================
+ Hits          739      785      +46     
+ Misses       2776     2722      -54     
- Partials      208      214       +6     
Impacted Files Coverage Δ
...t/cs/protocol/mqtt/handler/MqttConnectHandler.java 0.00% <0.00%> (ø)
...t/cs/protocol/mqtt/handler/MqttPublishHandler.java 0.00% <0.00%> (ø)
...cs/protocol/mqtt/handler/MqttSubscribeHandler.java 0.00% <0.00%> (ø)
.../rocketmq/mqtt/ds/store/LmqOffsetStoreManager.java 63.01% <0.00%> (+63.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f2a830...00a430e. Read the comment docs.

Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit 97c53a2 into apache:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LmqQueueStoreManager codeCov need to be increased and add unit test
3 participants