Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LmqQueueStoreManager codeCov need to be increased and add unit test #23

Closed
tianliuliu opened this issue Mar 11, 2022 · 0 comments · Fixed by #28
Closed

LmqQueueStoreManager codeCov need to be increased and add unit test #23

tianliuliu opened this issue Mar 11, 2022 · 0 comments · Fixed by #28
Labels
good first issue Good for newcomers

Comments

@tianliuliu
Copy link
Contributor

in branch main
rocketmq-mqtt/tree/main/mqtt-ds/src/main/java/org/apache/rocketmq/mqtt/ds/store/LmqOffsetStoreManager.java
LmqQueueStoreManager.java codeCov need to be increased

LmqQueueStoreManager.java
image
@ShannonDing ShannonDing added the good first issue Good for newcomers label Mar 11, 2022
tianliuliu added a commit to tianliuliu/rocketmq-mqtt that referenced this issue Mar 14, 2022
@tianliuliu
fix apache#23 add unit test to increase codeCov
66df196
tianliuliu added a commit to tianliuliu/rocketmq-mqtt that referenced this issue Mar 14, 2022
@tianliuliu
fix apache#23 add unit test to increase codeCov
a24dfa8
@tianliuliu tianliuliu mentioned this issue Mar 14, 2022
Merged
ShannonDing added a commit that referenced this issue Mar 14, 2022
@ShannonDing
[ISSUE #23]add unit test of lmqOffsetStoreManager
97c53a2 
[ISSUE #23]add unit test to increase codeCov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #23]add unit test to increase codeCov tianliuliu/rocketmq-mqtt
2 participants
@tianliuliu @ShannonDing