Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #17] check upstreamHookResult before enter message handler main logic #18

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

ChangingFond
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #18 (22b850d) into main (9939eab) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   19.84%   19.86%   +0.01%     
==========================================
  Files          87       87              
  Lines        3723     3721       -2     
  Branches      610      610              
==========================================
  Hits          739      739              
+ Misses       2776     2774       -2     
  Partials      208      208              
Impacted Files Coverage Δ
...t/cs/protocol/mqtt/handler/MqttConnectHandler.java 0.00% <0.00%> (ø)
...t/cs/protocol/mqtt/handler/MqttPublishHandler.java 0.00% <0.00%> (ø)
...cs/protocol/mqtt/handler/MqttSubscribeHandler.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9939eab...22b850d. Read the comment docs.

@pingww
Copy link
Contributor

pingww commented Mar 11, 2022

Yes, the code order here needs to be adjusted a bit

Copy link
Contributor

@tianliuliu tianliuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing added the enhancement New feature or request label Mar 11, 2022
@ShannonDing ShannonDing linked an issue Mar 14, 2022 that may be closed by this pull request
@ShannonDing ShannonDing merged commit 1eadae9 into apache:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check upstreamHookResult before enter message handler main logic
5 participants