Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check upstreamHookResult before enter message handler main logic #17

Closed
ChangingFond opened this issue Mar 11, 2022 · 1 comment · Fixed by #18
Closed

check upstreamHookResult before enter message handler main logic #17

ChangingFond opened this issue Mar 11, 2022 · 1 comment · Fixed by #18
Labels
enhancement New feature or request

Comments

@ChangingFond
Copy link
Contributor

image

Take MqttConnectHandler for example，as show in the above graph. While check upstream hook result return false in code block 2, schedule.schedule() method in code block 1 is unnecessary to run. So, moving code block 2 in front of 1 can reduce run time, maybe just a little, but it is according with what "upstream hook" means.
ChangingFond pushed a commit to ChangingFond/rocketmq-mqtt that referenced this issue Mar 11, 2022
[ISSUE apache#17] check upstreamHookResult before enter message handl…
2b725c5 
…er main logic
ChangingFond pushed a commit to ChangingFond/rocketmq-mqtt that referenced this issue Mar 11, 2022
[ISSUE apache#17] check upstreamHookResult before enter message handl…
22b850d 
…er main logic
@pingww
Copy link
Contributor

pingww commented Mar 11, 2022

Yes, need to return early

@ShannonDing ShannonDing added the enhancement New feature or request label Mar 11, 2022
@ShannonDing ShannonDing linked a pull request Mar 14, 2022 that will close this issue
[ISSUE #17] check upstreamHookResult before enter message handler main logic #18
Merged
ShannonDing added a commit that referenced this issue Mar 14, 2022
@ShannonDing
[ISSUE #17] check upstreamHookResult before enter message handler mai…
1eadae9 
…n logic

[ISSUE #17] check upstreamHookResult before enter message handler main logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@pingww @ChangingFond @ShannonDing