Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Move rules to dedicated directory #41

Merged
merged 6 commits into from
Apr 22, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,17 @@ To utilize Fractor effectively, follow these steps:
2. **Configuration**:
- Create a PHP configuration file (e.g., `fractor.php`) where you define the paths to your files.
- At minimum, a configuration file must specify the paths to process:
```php
<?php
```php
<?php

use a9f\Fractor\Fractor\DummyRule;
use a9f\FractorXml\XmlFileProcessor;
use a9f\Fractor\Configuration\Option;
use a9f\Typo3Fractor\Rules\FlexForm\AddRenderTypeToFlexFormFractor;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use a9f\Fractor\Configuration\Option;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator) {
$parameters = $containerConfigurator->parameters();
$parameters->set(Option::PATHS, [__DIR__ . '/output/']);
};
```
return static function (ContainerConfigurator $containerConfigurator) {
$parameters = $containerConfigurator->parameters();
$parameters->set(Option::PATHS, [__DIR__ . '/output/']);
};
```

3. **Running Fractor**:
- Execute Fractor from the command line, passing the path to your configuration file as an argument:
Expand Down
3 changes: 3 additions & 0 deletions e2e/typo3-flexform/fractor.php
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
<?php

use a9f\Fractor\Configuration\Option;
use a9f\Typo3Fractor\Set\Typo3LevelSetList;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$parameters = $containerConfigurator->parameters();
$parameters->set(Option::PATHS, [__DIR__ . '/output/']);

$containerConfigurator->import(Typo3LevelSetList::UP_TO_TYPO3_13);
};
7 changes: 5 additions & 2 deletions typo3-fractor/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@
},
"autoload": {
"psr-4": {
"a9f\\Typo3Fractor\\": "src/"
"a9f\\Typo3Fractor\\": [
"src",
"rules"
]
}
},
"autoload-dev": {
Expand All @@ -50,7 +53,7 @@
},
"scripts": {
"analyze:php": "phpstan analyze",
"docs:generate": "fractor-doc-generator generate src/Rules --output-file docs/typo3-fractor-rules.md",
"docs:generate": "fractor-doc-generator generate rules --output-file docs/typo3-fractor-rules.md",
"rector": "rector",
"style:php:check": "ecs",
"style:php:fix": "ecs --fix",
Expand Down
10 changes: 10 additions & 0 deletions typo3-fractor/config/level/up-to-typo3-10.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use a9f\Typo3Fractor\Set\Typo3LevelSetList;
use a9f\Typo3Fractor\Set\Typo3SetList;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$containerConfigurator->import(Typo3LevelSetList::UP_TO_TYPO3_9);
$containerConfigurator->import(Typo3SetList::TYPO3_10);
};
10 changes: 10 additions & 0 deletions typo3-fractor/config/level/up-to-typo3-11.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use a9f\Typo3Fractor\Set\Typo3LevelSetList;
use a9f\Typo3Fractor\Set\Typo3SetList;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$containerConfigurator->import(Typo3LevelSetList::UP_TO_TYPO3_10);
$containerConfigurator->import(Typo3SetList::TYPO3_11);
};
10 changes: 10 additions & 0 deletions typo3-fractor/config/level/up-to-typo3-12.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use a9f\Typo3Fractor\Set\Typo3LevelSetList;
use a9f\Typo3Fractor\Set\Typo3SetList;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$containerConfigurator->import(Typo3LevelSetList::UP_TO_TYPO3_11);
$containerConfigurator->import(Typo3SetList::TYPO3_12);
};
10 changes: 10 additions & 0 deletions typo3-fractor/config/level/up-to-typo3-13.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use a9f\Typo3Fractor\Set\Typo3LevelSetList;
use a9f\Typo3Fractor\Set\Typo3SetList;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$containerConfigurator->import(Typo3LevelSetList::UP_TO_TYPO3_12);
$containerConfigurator->import(Typo3SetList::TYPO3_13);
};
8 changes: 8 additions & 0 deletions typo3-fractor/config/level/up-to-typo3-7.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?php

use a9f\Typo3Fractor\Set\Typo3SetList;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$containerConfigurator->import(Typo3SetList::TYPO3_7);
};
10 changes: 10 additions & 0 deletions typo3-fractor/config/level/up-to-typo3-8.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use a9f\Typo3Fractor\Set\Typo3LevelSetList;
use a9f\Typo3Fractor\Set\Typo3SetList;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$containerConfigurator->import(Typo3LevelSetList::UP_TO_TYPO3_7);
$containerConfigurator->import(Typo3SetList::TYPO3_8);
};
10 changes: 10 additions & 0 deletions typo3-fractor/config/level/up-to-typo3-9.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use a9f\Typo3Fractor\Set\Typo3LevelSetList;
use a9f\Typo3Fractor\Set\Typo3SetList;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$containerConfigurator->import(Typo3LevelSetList::UP_TO_TYPO3_8);
$containerConfigurator->import(Typo3SetList::TYPO3_9);
};
10 changes: 10 additions & 0 deletions typo3-fractor/config/typo3-10.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$services = $containerConfigurator->services();
$services->defaults()
->autoconfigure()
->autowire();
};
10 changes: 10 additions & 0 deletions typo3-fractor/config/typo3-11.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$services = $containerConfigurator->services();
$services->defaults()
->autoconfigure()
->autowire();
};
10 changes: 10 additions & 0 deletions typo3-fractor/config/typo3-12.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$services = $containerConfigurator->services();
$services->defaults()
->autoconfigure()
->autowire();
};
10 changes: 10 additions & 0 deletions typo3-fractor/config/typo3-13.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$services = $containerConfigurator->services();
$services->defaults()
->autoconfigure()
->autowire();
};
12 changes: 12 additions & 0 deletions typo3-fractor/config/typo3-7.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?php

use a9f\Typo3Fractor\TYPO37\FlexForm\AddRenderTypeToFlexFormFractor;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$services = $containerConfigurator->services();
$services->defaults()
->autoconfigure()
->autowire();
$services->set(AddRenderTypeToFlexFormFractor::class);
};
10 changes: 10 additions & 0 deletions typo3-fractor/config/typo3-8.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$services = $containerConfigurator->services();
$services->defaults()
->autoconfigure()
->autowire();
};
10 changes: 10 additions & 0 deletions typo3-fractor/config/typo3-9.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$services = $containerConfigurator->services();
$services->defaults()
->autoconfigure()
->autowire();
};
2 changes: 1 addition & 1 deletion typo3-fractor/docs/typo3-fractor-rules.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

Add renderType node in FlexForm

- class: [`a9f\Typo3Fractor\Rules\FlexForm\AddRenderTypeToFlexFormFractor`](../src/Rules/FlexForm/AddRenderTypeToFlexFormFractor.php)
- class: [`a9f\Typo3Fractor\TYPO37\FlexForm\AddRenderTypeToFlexFormFractor`](../rules/TYPO37/FlexForm/AddRenderTypeToFlexFormFractor.php)

```diff
<T3DataStructure>
Expand Down
1 change: 1 addition & 0 deletions typo3-fractor/ecs.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
return (include __DIR__ . '/../.build/ecs.php')
->withPaths([
__DIR__ . '/config',
__DIR__ . '/rules',
__DIR__ . '/src',
__DIR__ . '/tests',
])
Expand Down
1 change: 1 addition & 0 deletions typo3-fractor/phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ parameters:
level: 8

paths:
- rules/
- src/
- tests/
1 change: 1 addition & 0 deletions typo3-fractor/rector.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
return (include __DIR__ . '/../.build/rector.php')
->withPaths([
__DIR__ . '/config',
__DIR__ . '/rules',
__DIR__ . '/src',
__DIR__ . '/tests',
]);
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace a9f\Typo3Fractor\Rules\FlexForm;
namespace a9f\Typo3Fractor\TYPO37\FlexForm;

use a9f\Typo3Fractor\AbstractFlexformFractor;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
Expand Down
43 changes: 43 additions & 0 deletions typo3-fractor/src/Set/Typo3LevelSetList.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<?php

declare(strict_types=1);

namespace a9f\Typo3Fractor\Set;

final class Typo3LevelSetList
{
/**
* @var string
*/
public const UP_TO_TYPO3_13 = __DIR__ . '/../../config/level/up-to-typo3-13.php';

/**
* @var string
*/
public const UP_TO_TYPO3_12 = __DIR__ . '/../../config/level/up-to-typo3-12.php';

/**
* @var string
*/
public const UP_TO_TYPO3_11 = __DIR__ . '/../../config/level/up-to-typo3-11.php';

/**
* @var string
*/
public const UP_TO_TYPO3_10 = __DIR__ . '/../../config/level/up-to-typo3-10.php';

/**
* @var string
*/
public const UP_TO_TYPO3_9 = __DIR__ . '/../../config/level/up-to-typo3-9.php';

/**
* @var string
*/
public const UP_TO_TYPO3_8 = __DIR__ . '/../../config/level/up-to-typo3-8.php';

/**
* @var string
*/
public const UP_TO_TYPO3_7 = __DIR__ . '/../../config/level/up-to-typo3-7.php';
}
43 changes: 43 additions & 0 deletions typo3-fractor/src/Set/Typo3SetList.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<?php

declare(strict_types=1);

namespace a9f\Typo3Fractor\Set;

final class Typo3SetList
{
/**
* @var string
*/
public const TYPO3_7 = __DIR__ . '/../../config/typo3-7.php';

/**
* @var string
*/
public const TYPO3_8 = __DIR__ . '/../../config/typo3-8.php';

/**
* @var string
*/
public const TYPO3_9 = __DIR__ . '/../../config/typo3-9.php';

/**
* @var string
*/
public const TYPO3_10 = __DIR__ . '/../../config/typo3-10.php';

/**
* @var string
*/
public const TYPO3_11 = __DIR__ . '/../../config/typo3-11.php';

/**
* @var string
*/
public const TYPO3_12 = __DIR__ . '/../../config/typo3-12.php';

/**
* @var string
*/
public const TYPO3_13 = __DIR__ . '/../../config/typo3-13.php';
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace a9f\Typo3Fractor\Tests\Rules\FlexForm;
namespace a9f\Typo3Fractor\Tests\Rules\TYPO37\FlexForm\AddRenderTypeToFlexFormFractor;

use a9f\Fractor\Testing\PHPUnit\AbstractFractorTestCase;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
<?php

use a9f\Fractor\Configuration\Option;
use a9f\Typo3Fractor\Set\Typo3SetList;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$containerConfigurator->import(__DIR__ . '/../../../../config/application.php');
$containerConfigurator->import(__DIR__ . '/../../../../../fractor-xml/config/application.php');
$containerConfigurator->import(__DIR__ . '/../../../../../../config/application.php');
$containerConfigurator->import(__DIR__ . '/../../../../../../../fractor-xml/config/application.php');
$containerConfigurator->import(Typo3SetList::TYPO3_7);

$parameters = $containerConfigurator->parameters();
$parameters->set(Option::PATHS, [__DIR__ . '/../Fixtures/']);
Expand Down