Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Move rules to dedicated directory #41

Merged
merged 6 commits into from
Apr 22, 2024
Merged

[FEATURE] Move rules to dedicated directory #41

merged 6 commits into from
Apr 22, 2024

Conversation

sabbelasichon
Copy link
Collaborator

No description provided.

Copy link
Owner

@andreaswolf andreaswolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, I would just add a more expressive API for adding a rule – services->set() is fine for people who know Symfony DI, but if you never used it in detail, that's just confusing. But maybe that's a good second step after this PR.

@sabbelasichon
Copy link
Collaborator Author

Looks good so far, I would just add a more expressive API for adding a rule – services->set() is fine for people who know Symfony DI, but if you never used it in detail, that's just confusing. But maybe that's a good second step after this PR.

I know. We should definitely improve it in the future.

@sabbelasichon sabbelasichon merged commit 665e26b into main Apr 22, 2024
28 checks passed
@sabbelasichon sabbelasichon deleted the issue-35 branch April 22, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants