-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Move rules to dedicated directory #41
Conversation
Resolves: #35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, I would just add a more expressive API for adding a rule – services->set()
is fine for people who know Symfony DI, but if you never used it in detail, that's just confusing. But maybe that's a good second step after this PR.
typo3-fractor/rules/TYPO37/FlexForm/AddRenderTypeToFlexFormFractor.php
Outdated
Show resolved
Hide resolved
.../Rules/TYPO37/FlexForm/AddRenderTypeToFlexFormFractor/AddRenderTypeToFlexFormFractorTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Andreas Wolf <[email protected]>
…ctor.php Co-authored-by: Andreas Wolf <[email protected]>
…ormFractor/AddRenderTypeToFlexFormFractorTest.php Co-authored-by: Andreas Wolf <[email protected]>
I know. We should definitely improve it in the future. |
No description provided.