MSVC complex number support in qiskit.h
#14037
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
Changelog: None
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 13902762051Details
💛 - Coveralls |
|
This is likely going to be superseded by #14030. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In MSVC complex numbers are structs called
_Dcomplex(forcomplex double) and_Fcomplex(forcomplex float). This commit covers the MSVC compiler.Details and comments
Tested on @anedumla's 64-bit windows machine and MSVC version 19.34.31933. Maybe we can add this to #14030 in case this gets windows CI to pass? Though there might be some extra work required..