Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC complex number support in qiskit.h #14037

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cryoris
Copy link
Contributor

@Cryoris Cryoris commented Mar 17, 2025

Summary

In MSVC complex numbers are structs called _Dcomplex (for complex double) and _Fcomplex (for complex float). This commit covers the MSVC compiler.

Details and comments

Tested on @anedumla's 64-bit windows machine and MSVC version 19.34.31933. Maybe we can add this to #14030 in case this gets windows CI to pass? Though there might be some extra work required..

@Cryoris Cryoris added Changelog: None Do not include in changelog C API Related to the C API labels Mar 17, 2025
@Cryoris Cryoris requested a review from a team as a code owner March 17, 2025 15:02
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13902762051

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 88.087%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 93.23%
Totals Coverage Status
Change from base Build 13902170881: 0.01%
Covered Lines: 72729
Relevant Lines: 82565

💛 - Coveralls

@Cryoris
Copy link
Contributor Author

Cryoris commented Mar 17, 2025

This is likely going to be superseded by #14030.

@Cryoris Cryoris added the on hold Can not fix yet label Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C API Related to the C API Changelog: None Do not include in changelog on hold Can not fix yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants