Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run C tests on all tier 1 platforms #14030

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mtreinish
Copy link
Member

Summary

This commit expands the testing matrix for the C API tests to cover all the supported tier 1 platforms. As tier 1 platforms we document that we test them all on every PR, historically that's just been the Python testing, but as we grow the capabilities of our C API in Qiskit we should expand that guarantee to testing on all the tier 1 platforms too.

There will need to be some iteration done to ensure they all work as expected, it's unlikely that this will work by default on Windows and we can tweak the configuration based on the results of CI runs.

Details and comments

This commit expands the testing matrix for the C API tests to cover all
the supported tier 1 platforms. As tier 1 platforms we document that we
test them all on every PR, historically that's just been the Python
testing, but as we grow the capabilities of our C API in Qiskit we
should expand that guarantee to testing on all the tier 1 platforms too.

There will need to be some iteration done to ensure they all work as
expected, it's unlikely that this will work by default on Windows and we
can tweak the configuration based on the results of CI runs.
@mtreinish mtreinish added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog C API Related to the C API labels Mar 15, 2025
@mtreinish mtreinish requested a review from a team as a code owner March 15, 2025 20:36
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Mar 15, 2025

Pull Request Test Coverage Report for Build 13909453855

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 248 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.06%) to 88.059%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/gate_metrics.rs 1 97.06%
qiskit/transpiler/passes/optimization/template_matching/template_substitution.py 1 93.27%
crates/accelerate/src/synthesis/clifford/bm_synthesis.rs 2 99.22%
crates/accelerate/src/synthesis/clifford/greedy_synthesis.rs 3 97.92%
crates/qasm2/src/lex.rs 6 91.73%
crates/accelerate/src/gate_direction.rs 7 96.95%
qiskit/circuit/tools/pi_check.py 9 91.3%
qiskit/circuit/parameterexpression.py 10 96.74%
crates/accelerate/src/commutation_cancellation.rs 13 89.77%
crates/accelerate/src/synthesis/evolution/pauli_network.rs 14 89.41%
Totals Coverage Status
Change from base Build 13896476661: -0.06%
Covered Lines: 72578
Relevant Lines: 82420

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C API Related to the C API Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants