-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run C tests on all tier 1 platforms #14030
Open
mtreinish
wants to merge
12
commits into
Qiskit:main
Choose a base branch
from
mtreinish:run-c-api-tests-on-all-platforms
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Run C tests on all tier 1 platforms #14030
mtreinish
wants to merge
12
commits into
Qiskit:main
from
mtreinish:run-c-api-tests-on-all-platforms
+116
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit expands the testing matrix for the C API tests to cover all the supported tier 1 platforms. As tier 1 platforms we document that we test them all on every PR, historically that's just been the Python testing, but as we grow the capabilities of our C API in Qiskit we should expand that guarantee to testing on all the tier 1 platforms too. There will need to be some iteration done to ensure they all work as expected, it's unlikely that this will work by default on Windows and we can tweak the configuration based on the results of CI runs.
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 13909453855Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
now use a macro to define MSVC custom complex number constructor
... of course...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C API
Related to the C API
Changelog: None
Do not include in changelog
type: qa
Issues and PRs that relate to testing and code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit expands the testing matrix for the C API tests to cover all the supported tier 1 platforms. As tier 1 platforms we document that we test them all on every PR, historically that's just been the Python testing, but as we grow the capabilities of our C API in Qiskit we should expand that guarantee to testing on all the tier 1 platforms too.
There will need to be some iteration done to ensure they all work as expected, it's unlikely that this will work by default on Windows and we can tweak the configuration based on the results of CI runs.
Details and comments