Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv20230905 (#87) #90

Merged
merged 5 commits into from
Sep 25, 2023
Merged

Nv20230905 (#87) #90

merged 5 commits into from
Sep 25, 2023

Conversation

ammsalme
Copy link
Contributor

@ammsalme ammsalme commented Sep 14, 2023

  • Update marc-record-validators-melinda, most fixes build on that (Nv20230905 marc-record-validators-melinda#212)

  • Improve X00 $e translations and subfield removals (improve MRA-422)
    ** If no cataloging language is specified in 040$b, translate stuff to default language ('fin') only if translation reduces the number of subfields (= translation of "$e composer, $e säveltäjä." leads to duplicate subfield which is then removed.)
    ** Note that there's still a minor bug "$e composer, $e kompositör" leads to default lang "$e säveltäjä".

  • Improve handling of pre publication note (500$a "EI VIELÄ ILMESTYNYT") (MRA-420)

  • Move field 505 normalization from here to validators and use it

  • Update 020 (et al) $q groupings (as nidottu is now kovakantinen etc) (MELINDA-8470) ** Use normalizeQualifyingInformation validator/fixer.

  • Remove some obsolete json (duplicate-but-worse MET-113 functionality)

  • Fix and update tests
    ** New test file (MRA-252)
    ** Update test with MRA-466 style 700$iat fields.

  • Update dependencies

  • 2.0.16-alpha.1

nvolk and others added 5 commits September 14, 2023 13:41
* Update marc-record-validators-melinda, most fixes build on that (Nv20230905 marc-record-validators-melinda#212)

* Improve X00 $e translations and subfield removals (improve MRA-422)
** If no cataloging language is specified in 040$b, translate stuff to default language ('fin') only if translation reduces the number of subfields (= translation of "$e composer, $e säveltäjä." leads to duplicate subfield which is then removed.)
** Note that there's still a minor bug "$e composer, $e kompositör" leads to default lang "$e säveltäjä".

* Improve handling of pre publication note (500$a "EI VIELÄ ILMESTYNYT") (MRA-420)

* Move field 505 normalization from here to validators and use it

* Update 020 (et al) $q groupings (as nidottu is now kovakantinen etc) (MELINDA-8470)
** Use normalizeQualifyingInformation validator/fixer.

* Remove some obsolete json (duplicate-but-worse MET-113 functionality)

*Fix and update tests
** New test file (MRA-252)
** Update test with MRA-466 style 700$iat fields.

* Update dependencies

* 2.0.16-alpha.1
* Bump actions/checkout from 3 to 4 (#86)
* Bump isbn3 from 1.1.40 to 1.1.41 (#84)
* Bump @natlibfi/melinda-commons from 13.0.5 to 13.0.6 (#82)
* Bump @natlibfi/marc-record from 7.2.4 to 7.3.1 (#80)
* Bump @natlibfi/marc-record-merge from 7.0.0-alpha.4 to 7.0.0 (#75)
@ammsalme ammsalme marked this pull request as ready for review September 25, 2023 09:01
@ammsalme ammsalme requested a review from a team as a code owner September 25, 2023 09:01
@ammsalme ammsalme merged commit 5028477 into main Sep 25, 2023
@ammsalme ammsalme deleted the dev branch September 25, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants