Nv20230905 #87
Merged
Nv20230905 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nvolk
commented
Sep 12, 2023
•
nvolk
commented
- use dev version of melinda-marc-record-validators, most fixes build on that (Nv20230905 marc-record-validators-melinda#212)
- improved translations and subfield removals in X00$e subfields (improve MRA-422)
- Fix MRA-420 here as well (500$a "EI VIELÄ ILMESTYNYT")
- Remove some obsolete json (duplicate-but-worse MET-113 functionality)
- Move field 505 normalization from here to validators and use it
- update 020 (et al) $q groupings (as nidottu is now kovakantinen etc)
- add merge tests that use to new/modifed validators
…nslated more aggressively
…nctions come from validator project)
They should be handled by the validator/fixer normalize-qualifying information.
…efault language ('fin') only if translation reduces the number of subfields (= translation of "$e composer, $e säveltäjä." leads to duplicate subfield which is then removed.)
Note that there's still a minor bug "$e composer, $e kompositör" leads to default lang "$e säveltäjä".
|
package yskii, koska se viittaa muun omaan validators-haaraan, josta kanssa tehty PR: NatLibFi/marc-record-validators-melinda#212 |
…es in both logic and architecture)
…ed and handled by a validator
…t repeatable subfield, use only the value that is in the base record)
ammsalme
approved these changes
Sep 14, 2023
ammsalme
added a commit
that referenced
this pull request
Sep 25, 2023
* Nv20230905 (#87) * Update marc-record-validators-melinda, most fixes build on that (Nv20230905 marc-record-validators-melinda#212) * Improve X00 $e translations and subfield removals (improve MRA-422) ** If no cataloging language is specified in 040$b, translate stuff to default language ('fin') only if translation reduces the number of subfields (= translation of "$e composer, $e säveltäjä." leads to duplicate subfield which is then removed.) ** Note that there's still a minor bug "$e composer, $e kompositör" leads to default lang "$e säveltäjä". * Improve handling of pre publication note (500$a "EI VIELÄ ILMESTYNYT") (MRA-420) * Move field 505 normalization from here to validators and use it * Update 020 (et al) $q groupings (as nidottu is now kovakantinen etc) (MELINDA-8470) ** Use normalizeQualifyingInformation validator/fixer. * Remove some obsolete json (duplicate-but-worse MET-113 functionality) *Fix and update tests ** New test file (MRA-252) ** Update test with MRA-466 style 700$iat fields. * Update dependencies * 2.0.16-alpha.1 * Dependency update (#91) * Bump actions/checkout from 3 to 4 (#86) * Bump isbn3 from 1.1.40 to 1.1.41 (#84) * Bump @natlibfi/melinda-commons from 13.0.5 to 13.0.6 (#82) * Bump @natlibfi/marc-record from 7.2.4 to 7.3.1 (#80) * Bump @natlibfi/marc-record-merge from 7.0.0-alpha.4 to 7.0.0 (#75) * 2.0.16-alpha.2 * Update to non-alpha validators: v10.13.1 * 2.0.16 --------- Co-authored-by: nvolk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.