Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv20230905 #87

Merged
merged 45 commits into from
Sep 14, 2023
Merged

Nv20230905 #87

merged 45 commits into from
Sep 14, 2023

Conversation

nvolk
Copy link
Contributor

@nvolk nvolk commented Sep 12, 2023

  • use dev version of melinda-marc-record-validators, most fixes build on that (Nv20230905 marc-record-validators-melinda#212)
  • improved translations and subfield removals in X00$e subfields (improve MRA-422)
  • Fix MRA-420 here as well (500$a "EI VIELÄ ILMESTYNYT")
  • Remove some obsolete json (duplicate-but-worse MET-113 functionality)
  • Move field 505 normalization from here to validators and use it
  • update 020 (et al) $q groupings (as nidottu is now kovakantinen etc)
  • add merge tests that use to new/modifed validators

nvolk added 30 commits September 5, 2023 14:14
They should be handled by the validator/fixer normalize-qualifying information.
…efault language ('fin') only if translation reduces the number of subfields (= translation of "$e composer, $e säveltäjä." leads to duplicate subfield which is then removed.)

Note that there's still a minor bug "$e composer, $e kompositör" leads to default lang "$e säveltäjä".
@nvolk nvolk requested a review from ammsalme September 12, 2023 21:14
@nvolk nvolk requested a review from a team as a code owner September 12, 2023 21:14
@nvolk
Copy link
Contributor Author

nvolk commented Sep 12, 2023

package yskii, koska se viittaa muun omaan validators-haaraan, josta kanssa tehty PR: NatLibFi/marc-record-validators-melinda#212

@ammsalme ammsalme changed the base branch from main to dev September 13, 2023 15:03
@ammsalme ammsalme merged commit b7f1c11 into dev Sep 14, 2023
ammsalme added a commit that referenced this pull request Sep 25, 2023
* Nv20230905 (#87)

* Update marc-record-validators-melinda, most fixes build on that (Nv20230905 marc-record-validators-melinda#212)

* Improve X00 $e translations and subfield removals (improve MRA-422)
** If no cataloging language is specified in 040$b, translate stuff to default language ('fin') only if translation reduces the number of subfields (= translation of "$e composer, $e säveltäjä." leads to duplicate subfield which is then removed.)
** Note that there's still a minor bug "$e composer, $e kompositör" leads to default lang "$e säveltäjä".

* Improve handling of pre publication note (500$a "EI VIELÄ ILMESTYNYT") (MRA-420)

* Move field 505 normalization from here to validators and use it

* Update 020 (et al) $q groupings (as nidottu is now kovakantinen etc) (MELINDA-8470)
** Use normalizeQualifyingInformation validator/fixer.

* Remove some obsolete json (duplicate-but-worse MET-113 functionality)

*Fix and update tests
** New test file (MRA-252)
** Update test with MRA-466 style 700$iat fields.

* Update dependencies

* 2.0.16-alpha.1

* Dependency update (#91)

* Bump actions/checkout from 3 to 4 (#86)
* Bump isbn3 from 1.1.40 to 1.1.41 (#84)
* Bump @natlibfi/melinda-commons from 13.0.5 to 13.0.6 (#82)
* Bump @natlibfi/marc-record from 7.2.4 to 7.3.1 (#80)
* Bump @natlibfi/marc-record-merge from 7.0.0-alpha.4 to 7.0.0 (#75)

* 2.0.16-alpha.2

* Update to non-alpha validators: v10.13.1

* 2.0.16

---------

Co-authored-by: nvolk <[email protected]>
@ammsalme ammsalme deleted the nv20230905 branch September 25, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants