General and Muuntaja-specific updates (#17) #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paikkasarjaa tommottiin: 6XX-kenttien yhdistymisrajoitteet ($vxyz pitää pariutua, eli $a foo $y ipsum ja $a foo $z lorum ei voi yhdistyä $a foo $y ipsum $z lorum -muotoon) $6-osakenttien korjauksia: siirrot 1XX<->7XX rikkoi välillä indeksit ja 880$6:n merkistöosa tippui välillä aiemmn matkasta 264:n ja 33X-kenttien toistettavat kentät pakotetaan ei-toistettavaksi (kummien mergejen esto) --------- * Update dependencies * Extend rules (mainly 6XX$v must pair). Fix tag 668 to 688. * Complicated test a bit (now with source 110->710 retagging) * Bug fix: don't lose script identification code. Also tune some debug messages. * Don't reindex legal value '00'. https://www.loc.gov/marc/bibliographic/ecbdcntf.html says: "When there is no associated field to which a field 880 is linked, the occurrence number in subfield$6 is 00. It is used if an agency wants to separate scripts in a record (see Multiscript Records). The linking tag part of subfield $6 will contain the tag that the associated regular field would have had if it had existed in the record." * smuggle $6 counterpart field 880 along, as 700$6 might merge with a field 100, and counterpart field 880's $6 might need to be changed. * Handle paired 880 field's $6 if a $6 subfield is merged to a different field (typically 700$6 => 100$6) * Add function resetSubfield6Tag(). Tune $6 acceptance regexp. * Relocate retagging so that $6-chain duplicates are handled before source's 1XX fields get retagged as 7XX fields. * Update copyright year * Make certain field-subfields non-repeatable (override standard to prevent crappy field merges) --------- Co-authored-by: Minttu Hurme <[email protected]>
* New file/test: MRA223 * Initial version of multi-$8 handling * Post processing: No longer remove identifier fields. Now done in muuntajaConfig.json. * Proper field 974 handling. Also move and refine rules. * Fix syntax error in 880$6 value * Refactor code, and move functions to subfield6Utils.js * update dependencies
Muuntaja updates: * Add functionality to copy 008/35-37 (language) from source to base * Update Muuntaja configuration * Relocate getCatalogingLanguage() to utils.js. Fix references to it. * Postprocessor now removes duplicate fields from base. * Postprocessor will now reset $6 indexes * Extend indicator rules (handles indicator difference in MRA-312) * Rewrite/relocate edition statement normalization * record-level duplicate removal: remove duplicate $6-linked field pairs as well * update dependencies * 1.2.0-alpha.3 --------- Co-authored-by: nvolk <[email protected]>
ammsalme
changed the title
* MRA-327 Handle $6 linkage correctly even if the slash preceding the script identification code is missing * MRA-287 ??? / MRA-308 Remove duplicate subfield $6 linked pairs from base Tweaks to subfield $6 reindexing * MRA-331 Ignore ind1 differences when checking if fields X00 are mergeable Normalise names in X00 to Firstname Lastname when checking if fields X00 are mergeable * MET-197 Do not merge field 245 $bnps * MET-193, MET-194 Do not use f250 (Edition statement) from source. * 1.2.0-alpha.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paikkasarjaa tommottiin:
6XX-kenttien yhdistymisrajoitteet ($vxyz pitää pariutua, eli $a foo $y ipsum ja $a foo $z lorum ei voi yhdistyä $a foo $y ipsum $z lorum -muotoon) $6-osakenttien korjauksia: siirrot 1XX<->7XX rikkoi välillä indeksit ja 880$6:n merkistöosa tippui välillä aiemmn matkasta 264:n ja 33X-kenttien toistettavat kentät pakotetaan ei-toistettavaksi (kummien mergejen esto)
Update dependencies
Extend rules (mainly 6XX$v must pair). Fix tag 668 to 688.
Complicated test a bit (now with source 110->710 retagging)
Bug fix: don't lose script identification code. Also tune some debug messages.
Don't reindex legal value '00'.
https://www.loc.gov/marc/bibliographic/ecbdcntf.html says: "When there is no associated field to which a field 880 is linked, the occurrence number in subfield$6 is 00. It is used if an agency wants to separate scripts in a record (see Multiscript Records). The linking tag part of subfield $6 will contain the tag that the associated regular field would have had if it had existed in the record."
smuggle $6 counterpart field 880 along, as 700$6 might merge with a field 100, and counterpart field 880's $6 might need to be changed.
Handle paired 880 field's $6 if a $6 subfield is merged to a different field (typically 700$6 => 100$6)
Add function resetSubfield6Tag(). Tune $6 acceptance regexp.
Relocate retagging so that $6-chain duplicates are handled before source's 1XX fields get retagged as 7XX fields.
Update copyright year
Make certain field-subfields non-repeatable (override standard to prevent crappy field merges) ---------
Co-authored-by: Minttu Hurme [email protected]