Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General and Muuntaja-specific updates (#17) #18

Merged
merged 6 commits into from
Feb 23, 2023
Merged

General and Muuntaja-specific updates (#17) #18

merged 6 commits into from
Feb 23, 2023

Conversation

ammsalme
Copy link
Contributor

@ammsalme ammsalme commented Feb 7, 2023

Paikkasarjaa tommottiin:

6XX-kenttien yhdistymisrajoitteet ($vxyz pitää pariutua, eli $a foo $y ipsum ja $a foo $z lorum ei voi yhdistyä $a foo $y ipsum $z lorum -muotoon) $6-osakenttien korjauksia: siirrot 1XX<->7XX rikkoi välillä indeksit ja 880$6:n merkistöosa tippui välillä aiemmn matkasta 264:n ja 33X-kenttien toistettavat kentät pakotetaan ei-toistettavaksi (kummien mergejen esto)


  • Update dependencies

  • Extend rules (mainly 6XX$v must pair). Fix tag 668 to 688.

  • Complicated test a bit (now with source 110->710 retagging)

  • Bug fix: don't lose script identification code. Also tune some debug messages.

  • Don't reindex legal value '00'.

https://www.loc.gov/marc/bibliographic/ecbdcntf.html says: "When there is no associated field to which a field 880 is linked, the occurrence number in subfield$6 is 00. It is used if an agency wants to separate scripts in a record (see Multiscript Records). The linking tag part of subfield $6 will contain the tag that the associated regular field would have had if it had existed in the record."

  • smuggle $6 counterpart field 880 along, as 700$6 might merge with a field 100, and counterpart field 880's $6 might need to be changed.

  • Handle paired 880 field's $6 if a $6 subfield is merged to a different field (typically 700$6 => 100$6)

  • Add function resetSubfield6Tag(). Tune $6 acceptance regexp.

  • Relocate retagging so that $6-chain duplicates are handled before source's 1XX fields get retagged as 7XX fields.

  • Update copyright year

  • Make certain field-subfields non-repeatable (override standard to prevent crappy field merges) ---------

Co-authored-by: Minttu Hurme [email protected]

nvolk and others added 5 commits February 7, 2023 13:45
Paikkasarjaa tommottiin:

6XX-kenttien yhdistymisrajoitteet ($vxyz pitää pariutua, eli $a foo $y ipsum ja $a foo $z lorum ei voi yhdistyä $a foo $y ipsum $z lorum -muotoon)
$6-osakenttien korjauksia: siirrot 1XX<->7XX rikkoi välillä indeksit ja 880$6:n merkistöosa tippui välillä aiemmn matkasta
264:n ja 33X-kenttien toistettavat kentät pakotetaan ei-toistettavaksi (kummien mergejen esto)

---------

* Update dependencies

* Extend rules (mainly 6XX$v must pair). Fix tag 668 to 688.
* Complicated test a bit (now with source 110->710 retagging)
* Bug fix: don't lose script identification code. Also tune some debug messages.
* Don't reindex legal value '00'.

https://www.loc.gov/marc/bibliographic/ecbdcntf.html says: "When there is no associated field to which a field 880 is linked, the occurrence number in subfield$6 is 00. It is used if an agency wants to separate scripts in a record (see Multiscript Records). The linking tag part of subfield $6 will contain the tag that the associated regular field would have had if it had existed in the record."

* smuggle $6 counterpart field 880 along, as 700$6 might merge with a field 100, and counterpart field 880's $6 might need to be changed.

* Handle paired 880 field's $6 if a $6 subfield is merged to a different field (typically 700$6 => 100$6)

* Add function resetSubfield6Tag(). Tune $6 acceptance regexp.
* Relocate retagging so that $6-chain duplicates are handled before source's 1XX fields get retagged as 7XX fields.

* Update copyright year

* Make certain field-subfields non-repeatable (override standard to prevent crappy field merges)
---------

Co-authored-by: Minttu Hurme <[email protected]>
* New file/test: MRA223
* Initial version of multi-$8 handling
* Post processing: No longer remove identifier fields. Now done in muuntajaConfig.json.
* Proper field 974 handling. Also move and refine rules.
* Fix syntax error in 880$6 value
* Refactor code, and move functions to subfield6Utils.js

* update dependencies
Muuntaja updates:
* Add functionality to copy 008/35-37 (language) from source to base
* Update Muuntaja configuration

* Relocate getCatalogingLanguage() to utils.js. Fix references to it.

* Postprocessor now removes duplicate fields from base.
* Postprocessor will now reset $6 indexes

* Extend indicator rules (handles indicator difference in MRA-312)

* Rewrite/relocate edition statement normalization

* record-level duplicate removal: remove duplicate $6-linked field pairs as well

* update dependencies

* 1.2.0-alpha.3

---------

Co-authored-by: nvolk <[email protected]>
@ammsalme ammsalme changed the title Mra219 et al (#17) General and Muuntaja-specific updates (#17) Feb 17, 2023
* MRA-327 
Handle $6 linkage correctly even if the slash preceding the script identification code is missing

* MRA-287 ??? / MRA-308
Remove duplicate subfield $6 linked pairs from base
Tweaks to subfield $6 reindexing

* MRA-331
Ignore ind1 differences when checking if fields X00 are mergeable
Normalise names in X00 to Firstname Lastname when checking if fields X00 are mergeable

* MET-197
Do not merge field 245 $bnps 

* MET-193, MET-194
Do not use f250 (Edition statement) from source.

* 1.2.0-alpha.4
@ammsalme ammsalme marked this pull request as ready for review February 23, 2023 09:28
@ammsalme ammsalme requested a review from a team as a code owner February 23, 2023 09:28
@ammsalme ammsalme merged commit 8543c15 into main Feb 23, 2023
@ammsalme ammsalme deleted the dev branch February 23, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants