Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mra219 et al #17

Merged
merged 26 commits into from
Feb 7, 2023
Merged

Mra219 et al #17

merged 26 commits into from
Feb 7, 2023

Conversation

nvolk
Copy link
Contributor

@nvolk nvolk commented Feb 6, 2023

Paikkasarjaa tommottiin:

  • 6XX-kenttien yhdistymisrajoitteet ($vxyz pitää pariutua, eli $a foo $y ipsum ja $a foo $z lorum ei voi yhdistyä $a foo $y ipsum $z lorum -muotoon)
  • $6-osakenttien korjauksia: siirrot 1XX<->7XX rikkoi välillä indeksit ja 880$6:n merkistöosa tippui välillä aiemmn matkasta
  • 264:n ja 33X-kenttien toistettavat kentät pakotetaan ei-toistettavaksi (kummien mergejen esto)

nvolk added 23 commits February 3, 2023 10:56
@nvolk
update dependencies
3bd99dc
@nvolk
add more cases to test
28ab271
@nvolk
Extend rules (mainly 6XX$v must pair). Fix tag 668 to 688.
e109695
@nvolk
New/relocated+changed test
60c2a43
@nvolk
update test description
78851a9
@nvolk
Complicated test a bit (now with source 110->710 retagging)
0b13400
@nvolk
modify test and it's description
ae31436
@nvolk
Tune a debug message
3fff911
@nvolk
Bug fix: don't lose script identification code. Also tune some debug …
383d5bb 
…messages.
@nvolk
Don't reindex legal value '00'.
fa20ef6 
https://www.loc.gov/marc/bibliographic/ecbdcntf.html says: "When there is no associated field to which a field 880 is linked, the occurrence number in subfield$6 is 00. It is used if an agency wants to separate scripts in a record (see Multiscript Records). The linking tag part of subfield $6 will contain the tag that the associated regular field would have had if it had existed in the record."
@nvolk
smuggle $6 counterpart field 880 along, as 700$6 might merge with a f…
3c19451 
…ield 100, and counterpart field 880's $6 might need to be changed.
@nvolk
Handle paired 880 field's $6 if a $6 subfield is merged to a differen…
ee5778b 
…t field (typically 700$6 => 100$6)
@nvolk
Add function resetSubfield6Tag(). Tune $6 acceptance regexp.
88c061e 
More debug messages.
@nvolk
Relocate retagging so that $6-chain duplicates are handled before sou…
d7f0958 
…rce's 1XX fields get retagged as 7XX fields.
@nvolk
Add comment/warning
744bd8f
@nvolk
Update comment to correspond with current implementation
1f02c91
@nvolk
Update copyright year
409f9fa
@nvolk
update dependencies
ad33600
@nvolk
Remove deleted file
df21cf4
@nvolk
Remove test
932e4c7
@nvolk
Remove test
ce14e57
@nvolk
New test (MRA231)
138750c
@nvolk
Make certain field-subfields non-repeatable (override standard to pre…
a3f3260 
…vent crappy field merges)
@nvolk nvolk requested a review from ammsalme February 6, 2023 21:19
@nvolk nvolk requested a review from a team as a code owner February 6, 2023 21:19
@ammsalme ammsalme merged commit b6096a5 into dev Feb 7, 2023
@ammsalme ammsalme deleted the MRA219_et_al branch February 14, 2023 15:29
ammsalme added a commit that referenced this pull request Feb 23, 2023
@ammsalme @nvolk
General and Muuntaja-specific updates (#17) (#18)
8543c15 
* Mra219 et al (#17)
* Muuntajaa eteenpäin ja MRA-263 (700/880$6-ketju) (#19)
* Muuntaja3 new (#21)
* Metatietoputki20230217 (#22)

---------

Co-authored-by: nvolk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammsalme ammsalme ammsalme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvolk @ammsalme