Cd to repo root before paramalarm #1805
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knoellle
force-pushed
the
position-independent-paramalarm
branch
from
4741ccf to
0c666eb
Compare
julianschuler
requested changes
Mar 17, 2025
| Some(path) => PathBuf::from(path), | ||
| None => PathBuf::from("."), | ||
| }; | ||
| let repository = Repository::find_root(repository_search_path).expect("no repository found"); |
There was a problem hiding this comment.
Why do use expect here instead of e.g. wrap_err and propagating the error?
|
|
||
| let file = | ||
| File::open(framework_parameters_path).wrap_err("failed to open framework parameters")?; | ||
| let file = File::open("etc/parameters/framework.json") |
There was a problem hiding this comment.
What do you think about joining this path with the repository root instead of first changing the current directory and then using a relative path?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
What it says. previously crashed because it was unable to find the json files.
Fixes #
ToDo / Known Issues
If this is a WIP describe which problems are to be fixed.
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test
Cd somewhere other than repo root and run parameter tester