-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searcher Standing Delay #1735
Open
paudar
wants to merge
3
commits into
HULKs:main
Choose a base branch
from
paudar:defender-searcher-delay
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Searcher Standing Delay #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5172c1e
to
30b2792
Compare
oleflb
requested changes
Mar 13, 2025
@@ -100,6 +104,18 @@ pub fn execute( | |||
}, | |||
None => HeadMotion::SearchForLostBall, | |||
}; | |||
let ball_eta = (ground_to_field.inverse() * last_known_ball_position) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pda
oleflb
requested changes
Mar 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, only need to fix test cases
17adfbd
to
effb203
Compare
40d7f8c
to
5b836c0
Compare
move functionality of delayed movement of defender that became earcher in searcher make the standing time after role change dynamic depending on last known ball posiiton add senario and fmt rename variable undo change of if condition add new edge detection change ball position in passive_defender_positioning
f72ab03
to
de3527d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
Suppress turning of an searcher for a dynamic time after role assignment.
The time depends on the distance to the last known ball position and is scaled with an parameter to estimate a hypothetical ball velocity in m/s.
Fixes #1395
Ideas for Next Iterations (Not This PR)
None
How to Test
You can see the effects in the
standing_searcher
-scenario.