Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replacement penalty striker #1733

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

JackyBloxx
Copy link
Contributor

@JackyBloxx JackyBloxx commented Mar 13, 2025

Why? What?

If we had a penalty kick and our striker got penelized we hadent any striker for the kick

Fixes #

ToDo / Known Issues

If this is a WIP describe which problems are to be fixed.

Ideas for Next Iterations (Not This PR)

If there are some improvements that could be done in a next iteration, describe them here.

How to Test

in a penalty kick penalize the striker and look if it got replaced
you could test it with bevi sim ingame_penalty_kick_striker_penalized

@JackyBloxx JackyBloxx force-pushed the add_replacement_penalty_striker branch from f84c885 to 8d4c505 Compare March 14, 2025 08:09
@oleflb
Copy link
Contributor

oleflb commented Mar 14, 2025

tested in the morning: did not work correctly. Somehow the penalty kick against invisibles was percepted as a penalty kick against Hulks

@JackyBloxx
Copy link
Contributor Author

that is because we never got a message which team is the kicking team, because of the new rules we only get that information from the hand gestures from the ref and not from the controler

@oleflb
Copy link
Contributor

oleflb commented Mar 14, 2025

this has to be postponed until after @ThagonDuarte merges the filter for free kicks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Request for Review
Development

Successfully merging this pull request may close these issues.

2 participants