Field color labeling and decision tree #1704
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Franziska-Sophie
force-pushed
the
field-color-detection
branch
from
1ea3453 to
a7e02a1
Compare
oleflb
requested changes
Mar 13, 2025
| @@ -0,0 +1 @@ | |||
| *.dot | |||
There was a problem hiding this comment.
you are missing an empty new line
| @@ -0,0 +1 @@ | |||
| from .generate_tree import optimize_thresholds, predict_image, save_tree_as_dot_file | |||
There was a problem hiding this comment.
same here, missing empty new line. Just run a uv run ruff format in the python workspace
| data_type: str | ||
|
|
||
|
|
||
| def convert_pixels_BGR2bgrI(pixel_BGR): |
There was a problem hiding this comment.
please add type info to parameters and return type
| return image_bgI | ||
|
|
||
|
|
||
| def optimize_thresholds(pixels_BGR, pixels_YCrCb, y, camera): |
There was a problem hiding this comment.
same here. Tip: use Literal["top", "bottom"] for camera (or define an enum)
Comment on lines
24
to
27
| print( | ||
| "ERROR: the parameter 'camera' in function 'optimize_thresholds' can only take the following values: ['top, 'bottom']" | ||
| ) | ||
| return |
There was a problem hiding this comment.
please raise Errors instead of printing
Comment on lines
9
to
13
| identifier: str | ||
| data_type: str |
There was a problem hiding this comment.
please add more specific types (Literal or enum)
Comment on lines
1
to
5
| import os | ||
| import cv2 | ||
| import numpy as np | ||
| import sys | ||
| import re | ||
| import tempfile | ||
| import time |
There was a problem hiding this comment.
please separate std import (os, system, re, time) from third-party imports by newline
Franziska-Sophie
force-pushed
the
field-color-detection
branch
from
a7e02a1 to
ed90504
Compare
schmidma
force-pushed
the
field-color-detection
branch
from
5689559 to
9c36821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
New pipeline for automatic field color calibration:
How to Test