add toggle between old calibration mode and new calibration mode #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleflb
requested changes
Jul 12, 2024
MaikRe
force-pushed
the
stand_there_and_say_ahhhh_for_the_doctor
branch
from
c702fb6 to
58743d7
Compare
oleflb
pushed a commit
to oleflb/hulk
that referenced
this pull request
Jul 15, 2024
…Ks#1159) * add toggle between old calibration mode and new calibration mode * false -> true
|
Thanks for adding this feature, I fully agree with your reasoning. Manual mode was unintentionally disabled when I introduced the new controller. |
1 task
oleflb
pushed a commit
that referenced
this pull request
Sep 30, 2024
* add toggle between old calibration mode and new calibration mode * false -> true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
I think completely removing the old calibration mode this close to an event could prove fatal if the new one isn't full functional #1115 or if and when people want to do manual adjustments, either during an event, or in the future to manually break camera matrices on purpose as we have done before for testing.
This adds a simple boolean toggle between the old and new calibration.
Feel free to suggest better naming
Fixes #
ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
How to Test
Setting the bool to false uses the new calibration which does (something) I guess?
Setting to true should make robot behave as before, i.e. stand up straight with the head stiffness at 0.