Fix being able to ctrl-k external factories #6699
Open
+9
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
You could ctrl-k external factories and they would be gone forever.
Description of the proposed changes
CanBeKilled
to false so that the factories cannot die..ExternalFactory
on the parent unit to interact with external factories, so the OnKilled callback no longer firing should also not be relevant.Testing done on the proposed changes
Checklist