-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move continuation capture methods from scope to tracer #8371
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~815385dba8, baseline=1.47.0-SNAPSHOT~a2be60e697
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045961
Total [baseline] (8.687 s) : 0, 8686740
Agent [candidate] (1.043 s) : 0, 1042672
Total [candidate] (8.635 s) : 0, 8634623
section iast
Agent [baseline] (1.175 s) : 0, 1174560
Total [baseline] (9.243 s) : 0, 9243368
Agent [candidate] (1.181 s) : 0, 1180984
Total [candidate] (9.312 s) : 0, 9311834
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.169 s) : 0, 1169472
Total [baseline] (9.257 s) : 0, 9257033
Agent [candidate] (1.169 s) : 0, 1169314
Total [candidate] (9.223 s) : 0, 9223336
section iast_TELEMETRY_OFF
Agent [baseline] (1.165 s) : 0, 1164772
Total [baseline] (9.207 s) : 0, 9207140
Agent [candidate] (1.178 s) : 0, 1178154
Total [candidate] (9.245 s) : 0, 9244515
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~815385dba8, baseline=1.47.0-SNAPSHOT~a2be60e697
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.138 ms) : 0, 722138
BytebuddyAgent [candidate] (717.098 ms) : 0, 717098
GlobalTracer [baseline] (240.629 ms) : 0, 240629
GlobalTracer [candidate] (241.1 ms) : 0, 241100
AppSec [baseline] (55.51 ms) : 0, 55510
AppSec [candidate] (55.537 ms) : 0, 55537
Remote Config [baseline] (711.35 µs) : 0, 711
Remote Config [candidate] (706.838 µs) : 0, 707
Telemetry [baseline] (11.558 ms) : 0, 11558
Telemetry [candidate] (13.045 ms) : 0, 13045
section iast
BytebuddyAgent [baseline] (837.857 ms) : 0, 837857
BytebuddyAgent [candidate] (842.56 ms) : 0, 842560
GlobalTracer [baseline] (231.642 ms) : 0, 231642
GlobalTracer [candidate] (233.16 ms) : 0, 233160
AppSec [baseline] (57.561 ms) : 0, 57561
AppSec [candidate] (57.492 ms) : 0, 57492
Remote Config [baseline] (621.625 µs) : 0, 622
Remote Config [candidate] (623.34 µs) : 0, 623
Telemetry [baseline] (8.832 ms) : 0, 8832
Telemetry [candidate] (8.795 ms) : 0, 8795
IAST [baseline] (22.746 ms) : 0, 22746
IAST [candidate] (22.936 ms) : 0, 22936
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.759 ms) : 0, 834759
BytebuddyAgent [candidate] (834.309 ms) : 0, 834309
GlobalTracer [baseline] (230.517 ms) : 0, 230517
GlobalTracer [candidate] (230.83 ms) : 0, 230830
AppSec [baseline] (57.059 ms) : 0, 57059
AppSec [candidate] (56.837 ms) : 0, 56837
Remote Config [baseline] (615.32 µs) : 0, 615
Remote Config [candidate] (616.888 µs) : 0, 617
Telemetry [baseline] (8.605 ms) : 0, 8605
Telemetry [candidate] (8.65 ms) : 0, 8650
IAST [baseline] (22.645 ms) : 0, 22645
IAST [candidate] (22.745 ms) : 0, 22745
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (830.093 ms) : 0, 830093
BytebuddyAgent [candidate] (839.383 ms) : 0, 839383
GlobalTracer [baseline] (230.882 ms) : 0, 230882
GlobalTracer [candidate] (233.7 ms) : 0, 233700
AppSec [baseline] (53.811 ms) : 0, 53811
AppSec [candidate] (52.863 ms) : 0, 52863
Remote Config [baseline] (607.975 µs) : 0, 608
Remote Config [candidate] (618.144 µs) : 0, 618
Telemetry [baseline] (8.647 ms) : 0, 8647
Telemetry [candidate] (8.776 ms) : 0, 8776
IAST [baseline] (25.546 ms) : 0, 25546
IAST [candidate] (27.445 ms) : 0, 27445
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~815385dba8, baseline=1.47.0-SNAPSHOT~a2be60e697
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047447
Total [baseline] (10.468 s) : 0, 10467705
Agent [candidate] (1.041 s) : 0, 1040823
Total [candidate] (10.469 s) : 0, 10469236
section appsec
Agent [baseline] (1.182 s) : 0, 1182139
Total [baseline] (10.752 s) : 0, 10752124
Agent [candidate] (1.184 s) : 0, 1183556
Total [candidate] (10.782 s) : 0, 10782174
section iast
Agent [baseline] (1.189 s) : 0, 1188945
Total [baseline] (11.059 s) : 0, 11058699
Agent [candidate] (1.179 s) : 0, 1179411
Total [candidate] (11.015 s) : 0, 11014957
section profiling
Agent [baseline] (1.262 s) : 0, 1262036
Total [baseline] (10.864 s) : 0, 10864138
Agent [candidate] (1.268 s) : 0, 1268254
Total [candidate] (10.884 s) : 0, 10884370
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~815385dba8, baseline=1.47.0-SNAPSHOT~a2be60e697
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.782 ms) : 0, 721782
BytebuddyAgent [candidate] (716.83 ms) : 0, 716830
GlobalTracer [baseline] (241.981 ms) : 0, 241981
GlobalTracer [candidate] (241.043 ms) : 0, 241043
AppSec [baseline] (55.527 ms) : 0, 55527
AppSec [candidate] (55.514 ms) : 0, 55514
Remote Config [baseline] (736.996 µs) : 0, 737
Remote Config [candidate] (721.658 µs) : 0, 722
Telemetry [baseline] (12.158 ms) : 0, 12158
Telemetry [candidate] (11.492 ms) : 0, 11492
section appsec
BytebuddyAgent [baseline] (732.746 ms) : 0, 732746
BytebuddyAgent [candidate] (734.033 ms) : 0, 734033
GlobalTracer [baseline] (237.584 ms) : 0, 237584
GlobalTracer [candidate] (237.401 ms) : 0, 237401
AppSec [baseline] (176.85 ms) : 0, 176850
AppSec [candidate] (177.126 ms) : 0, 177126
Remote Config [baseline] (660.295 µs) : 0, 660
Remote Config [candidate] (650.269 µs) : 0, 650
Telemetry [baseline] (8.251 ms) : 0, 8251
Telemetry [candidate] (8.227 ms) : 0, 8227
IAST [baseline] (21.665 ms) : 0, 21665
IAST [candidate] (21.715 ms) : 0, 21715
section iast
BytebuddyAgent [baseline] (849.057 ms) : 0, 849057
BytebuddyAgent [candidate] (841.774 ms) : 0, 841774
GlobalTracer [baseline] (234.054 ms) : 0, 234054
GlobalTracer [candidate] (232.419 ms) : 0, 232419
AppSec [baseline] (57.655 ms) : 0, 57655
AppSec [candidate] (57.495 ms) : 0, 57495
Remote Config [baseline] (627.705 µs) : 0, 628
Remote Config [candidate] (622.423 µs) : 0, 622
Telemetry [baseline] (8.824 ms) : 0, 8824
Telemetry [candidate] (8.828 ms) : 0, 8828
IAST [baseline] (23.057 ms) : 0, 23057
IAST [candidate] (22.889 ms) : 0, 22889
section profiling
BytebuddyAgent [baseline] (707.015 ms) : 0, 707015
BytebuddyAgent [candidate] (711.592 ms) : 0, 711592
GlobalTracer [baseline] (351.329 ms) : 0, 351329
GlobalTracer [candidate] (353.109 ms) : 0, 353109
AppSec [baseline] (55.429 ms) : 0, 55429
AppSec [candidate] (54.566 ms) : 0, 54566
Remote Config [baseline] (693.154 µs) : 0, 693
Remote Config [candidate] (713.964 µs) : 0, 714
Telemetry [baseline] (8.855 ms) : 0, 8855
Telemetry [candidate] (8.981 ms) : 0, 8981
ProfilingAgent [baseline] (96.354 ms) : 0, 96354
ProfilingAgent [candidate] (96.685 ms) : 0, 96685
Profiling [baseline] (96.378 ms) : 0, 96378
Profiling [candidate] (96.709 ms) : 0, 96709
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~815385dba8, baseline=1.47.0-SNAPSHOT~a2be60e697
dateFormat X
axisFormat %s
section baseline
no_agent (389.511 µs) : 370, 409
. : milestone, 390,
iast (511.508 µs) : 490, 533
. : milestone, 512,
iast_FULL (746.193 µs) : 724, 768
. : milestone, 746,
iast_GLOBAL (554.497 µs) : 533, 576
. : milestone, 554,
iast_HARDCODED_SECRET_DISABLED (516.12 µs) : 494, 538
. : milestone, 516,
iast_INACTIVE (457.954 µs) : 437, 479
. : milestone, 458,
iast_TELEMETRY_OFF (508.661 µs) : 485, 532
. : milestone, 509,
tracing (459.659 µs) : 437, 482
. : milestone, 460,
section candidate
no_agent (383.636 µs) : 364, 404
. : milestone, 384,
iast (511.136 µs) : 488, 534
. : milestone, 511,
iast_FULL (748.362 µs) : 726, 770
. : milestone, 748,
iast_GLOBAL (554.62 µs) : 533, 576
. : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (516.863 µs) : 495, 539
. : milestone, 517,
iast_INACTIVE (465.182 µs) : 444, 487
. : milestone, 465,
iast_TELEMETRY_OFF (507.453 µs) : 485, 530
. : milestone, 507,
tracing (454.786 µs) : 434, 476
. : milestone, 455,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~815385dba8, baseline=1.47.0-SNAPSHOT~a2be60e697
dateFormat X
axisFormat %s
section baseline
no_agent (1.345 ms) : 1326, 1364
. : milestone, 1345,
appsec (1.746 ms) : 1722, 1769
. : milestone, 1746,
appsec_no_iast (1.777 ms) : 1753, 1801
. : milestone, 1777,
iast (1.514 ms) : 1490, 1539
. : milestone, 1514,
profiling (1.575 ms) : 1550, 1600
. : milestone, 1575,
tracing (1.514 ms) : 1490, 1538
. : milestone, 1514,
section candidate
no_agent (1.38 ms) : 1361, 1400
. : milestone, 1380,
appsec (1.763 ms) : 1739, 1786
. : milestone, 1763,
appsec_no_iast (1.774 ms) : 1750, 1797
. : milestone, 1774,
iast (1.495 ms) : 1471, 1519
. : milestone, 1495,
profiling (1.593 ms) : 1568, 1618
. : milestone, 1593,
tracing (1.514 ms) : 1490, 1538
. : milestone, 1514,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~815385dba8, baseline=1.47.0-SNAPSHOT~46fd85c884
dateFormat X
axisFormat %s
section baseline
no_agent (15.504 s) : 15504000, 15504000
. : milestone, 15504000,
appsec (15.059 s) : 15059000, 15059000
. : milestone, 15059000,
iast (18.497 s) : 18497000, 18497000
. : milestone, 18497000,
iast_GLOBAL (17.547 s) : 17547000, 17547000
. : milestone, 17547000,
profiling (15.015 s) : 15015000, 15015000
. : milestone, 15015000,
tracing (15.12 s) : 15120000, 15120000
. : milestone, 15120000,
section candidate
no_agent (15.413 s) : 15413000, 15413000
. : milestone, 15413000,
appsec (15.167 s) : 15167000, 15167000
. : milestone, 15167000,
iast (18.68 s) : 18680000, 18680000
. : milestone, 18680000,
iast_GLOBAL (18.087 s) : 18087000, 18087000
. : milestone, 18087000,
profiling (15.003 s) : 15003000, 15003000
. : milestone, 15003000,
tracing (14.931 s) : 14931000, 14931000
. : milestone, 14931000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~815385dba8, baseline=1.47.0-SNAPSHOT~46fd85c884
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (2.357 ms) : 2314, 2401
. : milestone, 2357,
iast (2.105 ms) : 2050, 2160
. : milestone, 2105,
iast_GLOBAL (2.154 ms) : 2098, 2209
. : milestone, 2154,
profiling (1.958 ms) : 1914, 2001
. : milestone, 1958,
tracing (1.951 ms) : 1908, 1993
. : milestone, 1951,
section candidate
no_agent (1.465 ms) : 1453, 1476
. : milestone, 1465,
appsec (2.36 ms) : 2317, 2403
. : milestone, 2360,
iast (2.112 ms) : 2057, 2167
. : milestone, 2112,
iast_GLOBAL (2.152 ms) : 2096, 2207
. : milestone, 2152,
profiling (1.958 ms) : 1914, 2002
. : milestone, 1958,
tracing (1.94 ms) : 1898, 1982
. : milestone, 1940,
|
3da5580
to
e0f227e
Compare
e0f227e
to
035db7f
Compare
0f31303
to
a7ada65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
We keep adding deprecated / for removal methods to the public Tracer
API but I can't think of another way to do it 🤷
One question though, should we migrate calls to TraceScope.capture()
to the new API already? -- to stop from using it in the code base
You mean instrumentation use of |
Yes, exactly. I wasn't sure migration/evolution of the AgentTracer API and internals includes the use of those API 😄 |
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#​8483](DataDog/dd-trace-java#8483) - [@​jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#​8462](DataDog/dd-trace-java#8462) - [@​jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#​8408](DataDog/dd-trace-java#8408) - [@​smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#​8407](DataDog/dd-trace-java#8407) - [@​smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#​8406](DataDog/dd-trace-java#8406) - [@​smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#​8347](DataDog/dd-trace-java#8347) - [@​jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#​8219](DataDog/dd-trace-java#8219) - [@​jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#​8210](DataDog/dd-trace-java#8210) - [@​jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#​8205](DataDog/dd-trace-java#8205) - [@​sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#​8376](DataDog/dd-trace-java#8376) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#​8374](DataDog/dd-trace-java#8374) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#​8354](DataDog/dd-trace-java#8354) - [@​sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#​8353](DataDog/dd-trace-java#8353) - [@​Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#​8285](DataDog/dd-trace-java#8285) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#​8280](DataDog/dd-trace-java#8280) - [@​Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#​8219](DataDog/dd-trace-java#8219) - [@​jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#​8361](DataDog/dd-trace-java#8361) - [@​amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#​8180](DataDog/dd-trace-java#8180) - [@​lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#​8487](DataDog/dd-trace-java#8487) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#​8484](DataDog/dd-trace-java#8484) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#​8474](DataDog/dd-trace-java#8474) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#​8467](DataDog/dd-trace-java#8467) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#​8465](DataDog/dd-trace-java#8465) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#​8451](DataDog/dd-trace-java#8451) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#​8445](DataDog/dd-trace-java#8445) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#​8444](DataDog/dd-trace-java#8444) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#​8393](DataDog/dd-trace-java#8393) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#​8377](DataDog/dd-trace-java#8377) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#​8349](DataDog/dd-trace-java#8349) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#​8345](DataDog/dd-trace-java#8345) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#​8331](DataDog/dd-trace-java#8331) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#​8326](DataDog/dd-trace-java#8326) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#​8320](DataDog/dd-trace-java#8320) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#​8318](DataDog/dd-trace-java#8318) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#​8419](DataDog/dd-trace-java#8419) - [@​mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#​8348](DataDog/dd-trace-java#8348) - [@​jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#​8473](DataDog/dd-trace-java#8473) - [@​vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#​8403](DataDog/dd-trace-java#8403) - [@​vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#​8387](DataDog/dd-trace-java#8387) - [@​piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#​8508](DataDog/dd-trace-java#8508) - [@​cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#​8468](DataDog/dd-trace-java#8468) - [@​evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#​8452](DataDog/dd-trace-java#8452) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#​8416](DataDog/dd-trace-java#8416) - [@​evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#​8370](DataDog/dd-trace-java#8370) - [@​jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#​8369](DataDog/dd-trace-java#8369) - [@​jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#​8344](DataDog/dd-trace-java#8344) - [@​jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#​8319](DataDog/dd-trace-java#8319) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#​8301](DataDog/dd-trace-java#8301) - [@​evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#​8381](DataDog/dd-trace-java#8381) - [@​sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#​8364](DataDog/dd-trace-java#8364) - [@​sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#​8463](DataDog/dd-trace-java#8463) - [@​jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#​8456](DataDog/dd-trace-java#8456) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#​8431](DataDog/dd-trace-java#8431) - [@​jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#​8420](DataDog/dd-trace-java#8420) - [@​mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#​8419](DataDog/dd-trace-java#8419) - [@​mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#​8405](DataDog/dd-trace-java#8405) - [@​jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#​8342](DataDog/dd-trace-java#8342) - [@​MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#​8428](DataDog/dd-trace-java#8428) - [@​jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#​8353](DataDog/dd-trace-java#8353) - [@​Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#​8313](DataDog/dd-trace-java#8313) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#​8460](DataDog/dd-trace-java#8460) - [@​BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#​8414](DataDog/dd-trace-java#8414) - [@​mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#​8399](DataDog/dd-trace-java#8399) - [@​mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#​8383](DataDog/dd-trace-java#8383) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#​8371](DataDog/dd-trace-java#8371) - [@​mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#​8368](DataDog/dd-trace-java#8368) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#​8358](DataDog/dd-trace-java#8358) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#​8338](DataDog/dd-trace-java#8338) - [@​mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#​8330](DataDog/dd-trace-java#8330) - [@​mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#​8324](DataDog/dd-trace-java#8324) - [@​mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#​8313](DataDog/dd-trace-java#8313) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#​8271](DataDog/dd-trace-java#8271) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#​8417](DataDog/dd-trace-java#8417) - [@​nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#​8473](DataDog/dd-trace-java#8473) - [@​vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#​7585](DataDog/dd-trace-java#7585) - [@​DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#​8468](DataDog/dd-trace-java#8468) - [@​evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#​8416](DataDog/dd-trace-java#8416) - [@​evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#​8330](DataDog/dd-trace-java#8330) - [@​mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#​8301](DataDog/dd-trace-java#8301) - [@​evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#​8468](DataDog/dd-trace-java#8468) - [@​evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#​8366](DataDog/dd-trace-java#8366) - [@​rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#​8403](DataDog/dd-trace-java#8403) - [@​vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa
What Does This Do
TraceScope.capture()
now delegates toTracer.captureActiveSpan()
- when asynchronous propagation is enabled, this method prevents the currently active trace from reporting until the returned continuation is either activated (and the returned scope is closed) or the continuation is canceledNote: previously it was technically possible to call
TraceScope.capture()
on a scope which wasn't part of the currently active trace. This is no longer allowed, callingcapture()
will now always capture the active trace at that point. In practice this shouldn't make any difference because this API was used to capture active scopes.Motivation
We want to move away from the old scope-specific API towards tracer methods that work on the active span/trace.
Additional Notes
Further migration/evolution of the
AgentTracer
API and internals will be covered in a separate PR.Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APMAPI-955